All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: add --disable-zlib-test
Date: Fri, 29 Jul 2011 09:37:48 -0500	[thread overview]
Message-ID: <4E32C5BC.3090902@codemonkey.ws> (raw)
In-Reply-To: <1311672640-18000-1-git-send-email-alevy@redhat.com>

On 07/26/2011 04:30 AM, Alon Levy wrote:
> This is required for building libcacard which doesn't itself require
> zlib without bringing in this requirement to the build environment.
>
> Signed-off-by: Alon Levy<alevy@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> I'd like this to go into 0.15.0 too, it makes building libcacard possible
> without zlib-devel being installed.
> ---
>   configure |   23 ++++++++++++++---------
>   1 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/configure b/configure
> index 88159ac..5fc0f82 100755
> --- a/configure
> +++ b/configure
> @@ -178,6 +178,7 @@ rbd=""
>   smartcard=""
>   smartcard_nss=""
>   opengl=""
> +zlib="yes"
>
>   # parse CC options first
>   for opt do
> @@ -743,6 +744,8 @@ for opt do
>     ;;
>     --enable-smartcard-nss) smartcard_nss="yes"
>     ;;
> +  --disable-zlib-test) zlib="no"
> +  ;;
>     *) echo "ERROR: unknown option $opt"; show_help="yes"
>     ;;
>     esac
> @@ -1172,18 +1175,20 @@ fi
>   ##########################################
>   # zlib check
>
> -cat>  $TMPC<<  EOF
> +if test "$zlib" != "no" ; then
> +    cat>  $TMPC<<  EOF
>   #include<zlib.h>
>   int main(void) { zlibVersion(); return 0; }
>   EOF
> -if compile_prog "" "-lz" ; then
> -    :
> -else
> -    echo
> -    echo "Error: zlib check failed"
> -    echo "Make sure to have the zlib libs and headers installed."
> -    echo
> -    exit 1
> +    if compile_prog "" "-lz" ; then
> +        :
> +    else
> +        echo
> +        echo "Error: zlib check failed"
> +        echo "Make sure to have the zlib libs and headers installed."
> +        echo
> +        exit 1
> +    fi
>   fi
>
>   ##########################################

      reply	other threads:[~2011-07-29 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26  9:30 [Qemu-devel] [PATCH] configure: add --disable-zlib-test Alon Levy
2011-07-29 14:37 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E32C5BC.3090902@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.