From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.fusionio.com ([66.114.96.31]:45481 "EHLO mx2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703Ab1GaTbQ (ORCPT ); Sun, 31 Jul 2011 15:31:16 -0400 Message-ID: <4E35A9B1.9090309@fusionio.com> Date: Sun, 31 Jul 2011 21:14:57 +0200 From: Jens Axboe To: Christoph Hellwig CC: Trond Myklebust , Linus Torvalds , , , Subject: Re: Please pull NFS client changes References: <1312082377.10882.1.camel@lade.trondhjem.org> <20110731182406.GA16470@infradead.org> In-Reply-To: <20110731182406.GA16470@infradead.org> Content-Type: text/plain; charset="windows-1252" Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On 2011-07-31 20:24, Christoph Hellwig wrote: > How does this manage to include the pnfs block code, which only was posted > on the list a few hours before the pull request, and which doesn't > appear to past testing very well (although the major issue seems to be > core nfs code)? And it doesn't even compile: In file included from fs/nfs/client.c:51:0: fs/nfs/pnfs.h:384:1: error: expected identifier or ‘(’ before ‘{’ token fs/nfs/client.c: In function ‘nfs_server_set_fsinfo’: fs/nfs/client.c:939:8: error: ‘struct nfs_server’ has no member named ‘pnfs_blksize’ fs/nfs/client.c: At top level: fs/nfs/pnfs.h:382:20: warning: ‘set_pnfs_layoutdriver’ used but never defined [enabled by default] make[2]: *** [fs/nfs/client.o] Error 1 -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: Please pull NFS client changes Date: Sun, 31 Jul 2011 21:14:57 +0200 Message-ID: <4E35A9B1.9090309@fusionio.com> References: <1312082377.10882.1.camel@lade.trondhjem.org> <20110731182406.GA16470@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Trond Myklebust , Linus Torvalds , , , To: Christoph Hellwig Return-path: Received: from mx2.fusionio.com ([66.114.96.31]:45442 "EHLO mx2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370Ab1GaTPI (ORCPT ); Sun, 31 Jul 2011 15:15:08 -0400 In-Reply-To: <20110731182406.GA16470@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2011-07-31 20:24, Christoph Hellwig wrote: > How does this manage to include the pnfs block code, which only was p= osted > on the list a few hours before the pull request, and which doesn't > appear to past testing very well (although the major issue seems to b= e > core nfs code)? And it doesn't even compile: In file included from fs/nfs/client.c:51:0: fs/nfs/pnfs.h:384:1: error: expected identifier or =91(=92 before =91{=92= token fs/nfs/client.c: In function =91nfs_server_set_fsinfo=92: fs/nfs/client.c:939:8: error: =91struct nfs_server=92 has no member nam= ed =91pnfs_blksize=92 fs/nfs/client.c: At top level: fs/nfs/pnfs.h:382:20: warning: =91set_pnfs_layoutdriver=92 used but nev= er defined [enabled by default] make[2]: *** [fs/nfs/client.o] Error 1 --=20 Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html