From: Jon Forrest <nobozo@gmail.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] For Real - Fixed pluralization in diff reports
Date: Sun, 31 Jul 2011 21:57:02 -0700 [thread overview]
Message-ID: <4E36321E.2040409@gmail.com> (raw)
In-Reply-To: <CACsJy8CdfRCssfrMVOjRn2a_=vZPLyG_uEd4fS2WxzQXKZGn3w@mail.gmail.com>
On 7/31/2011 9:50 PM, Nguyen Thai Ngoc Duy wrote:
> Are you sure this does not break any tests? t3508.2 for example
> hardcodes "1 insertions" and does textual compare. I have not run the
> tests but I suspect it will fail.
I ran the tests. The only result in red that I saw that
didn't appear to be caused "by breakage" was
not ok - 3 mktemp to unwritable directory prints filename
Since I didn't do anything relating to mktemp I thought
this was probably bogus.
I'm new to this so I don't know how to find the t3508.2.
If you can give me a hint I'd be glad to look at this in
more detail.
Jon
next prev parent reply other threads:[~2011-08-01 4:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 4:46 [PATCH] For Real - Fixed pluralization in diff reports Jon Forrest
2011-08-01 4:50 ` Nguyen Thai Ngoc Duy
2011-08-01 4:57 ` Jon Forrest [this message]
2011-08-01 5:21 ` Nguyen Thai Ngoc Duy
2011-08-01 9:58 ` Sverre Rabbelier
2011-08-01 14:32 ` Jon Forrest
2011-08-01 18:06 ` Jeff King
2011-08-01 18:27 ` Jon Forrest
2011-08-01 18:32 ` Sverre Rabbelier
2011-08-01 18:38 ` Jeff King
2011-08-03 13:38 ` Jakub Narebski
2011-08-03 16:52 ` Jon Forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36321E.2040409@gmail.com \
--to=nobozo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.