Re: [PATCH 10/22] tune/arch-powerpc: Use fpu-soft to set PPCPKGSFX_FPU

From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 10/22] tune/arch-powerpc: Use fpu-soft to set PPCPKGSFX_FPU
Date: Mon, 1 Aug 2011 09:50:52 -0500	[thread overview]
Message-ID: <4E36BD4C.4030909@windriver.com> (raw)
In-Reply-To: <00381DE4-B22F-4F08-BE72-8D314B8CEF15@kernel.crashing.org>

On 8/1/11 9:13 AM, Kumar Gala wrote:
> 
> On Aug 1, 2011, at 8:03 AM, Richard Purdie wrote:
> 
>> On Mon, 2011-08-01 at 00:36 -0700, Saul Wold wrote:
>>> From: Kumar Gala <galak@kernel.crashing.org>
>>>
>>> Its more likely that we explicitly set soft-floating point support for a
>>> given target than hard.  So use 'fpu-soft' in TUNE_FEATURES rather than
>>> 'fpu-hard' to determine setting 'nf' (no-float) in PPCPKGSFX_FPU.
>>>
>>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>>> ---
>>> meta/conf/machine/include/powerpc/arch-powerpc.inc |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> index 8cc76ab..013755d 100644
>>> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> @@ -18,7 +18,7 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)}
>>>
>>> ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}"
>>>
>>> -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
>>> +PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "-nf", "", d)}"
>>>
>>> TUNE_PKGARCH ?= "${TUNE_ARCH}${PPCPKGSFX_FPU}"
>>
>> Whilst the change itself may or may not be ok, it would need to change
>> the various boards that are already setting or not setting fpu-hard as a
>> feature so as it stands this change is incomplete.
> 
> Which boards are you speaking of?  I'm not aware of any that set soft float at this point for PPC.

It shouldn't be the board setting it to soft-fp, but instead the tune.
Something like qemuppc can use the nf 603e tune.

--Mark

> - k
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core