From: Josef Bacik <josef@redhat.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices V2
Date: Mon, 01 Aug 2011 11:24:32 -0400 [thread overview]
Message-ID: <4E36C530.5030003@redhat.com> (raw)
In-Reply-To: <1312205910-13053-1-git-send-email-apw@canonical.com>
On 08/01/2011 09:38 AM, Andy Whitcroft wrote:
> When we mount a btrfs filesystem from read-only media there will be no
> read/write devices; for example mounting an SD card with its lock enabled.
> This triggers an immediate BUG during mount:
>
> kernel BUG at .../fs/btrfs/super.c:984!
>
> This is triggered by statfs when calculating the free space in the
> filesytem. We bug if the number of read/write devices is 0.
>
> This check seems spurious as the information collected is valid regardless
> of whether the devices are read-only or not. As the count is used to
> size the sort array it seems more correct to switch it to the number of
> open devices.
>
> BugLink: http://bugs.launchpad.net/bugs/816770
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Josef Bacik <josef@redhat.com>
Thanks,
Josef
next prev parent reply other threads:[~2011-08-01 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 13:38 [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices V2 Andy Whitcroft
2011-08-01 15:24 ` Josef Bacik [this message]
2011-11-28 12:11 ` Jonathan Nieder
2011-11-28 12:24 ` Andy Whitcroft
2011-11-29 1:26 ` Li Zefan
2011-11-29 6:01 ` Jonathan Nieder
2011-11-30 15:40 ` Andy Whitcroft
2011-11-29 1:55 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36C530.5030003@redhat.com \
--to=josef@redhat.com \
--cc=apw@canonical.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.