From: Bob Breuer <breuerr@mc.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Sparc: fix non-faulting unassigned memory accesses
Date: Tue, 02 Aug 2011 00:59:54 -0500 [thread overview]
Message-ID: <4E37925A.6010800@mc.net> (raw)
In-Reply-To: <CAAu8pHs-hr15q2UGXmrKUSgJqMZO1noC5TGLB5GFsNdRD_PPjg@mail.gmail.com>
Blue Swirl wrote:
> Commit b14ef7c9ab41ea824c3ccadb070ad95567cca84e
> introduced cpu_unassigned_access() function. On Sparc,
> the function does not restore AREG0 used for global CPUState
> on function exit, causing bugs with non-faulting unassigned
> memory accesses. Alpha, Microblaze and MIPS are not affected.
>
> Fix by restoring AREG0 on exit. Remove excess saving by
> do_unassigned_access() functions.
>
> Also ignore unassigned accesses outside of CPU context.
>
> Reported-by: Bob Breuer <breuerr@mc.net>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> target-sparc/op_helper.c | 25 ++++++++-----------------
> 1 files changed, 8 insertions(+), 17 deletions(-)
>
[snip]
Works for my testcases.
Tested-by: Bob Breuer <breuerr@mc.net>
next prev parent reply other threads:[~2011-08-02 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 21:31 [Qemu-devel] [PATCH] Sparc: fix non-faulting unassigned memory accesses Blue Swirl
2011-08-02 5:59 ` Bob Breuer [this message]
2011-08-03 16:55 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E37925A.6010800@mc.net \
--to=breuerr@mc.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.