From: Josef Bacik <josef@redhat.com>
To: liubo <liubo2009@cn.fujitsu.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: skip looking for delalloc if we don't have ->fill_delalloc
Date: Tue, 02 Aug 2011 08:24:58 -0400 [thread overview]
Message-ID: <4E37EC9A.20908@redhat.com> (raw)
In-Reply-To: <4E37564F.1040902@cn.fujitsu.com>
On 08/01/2011 09:43 PM, liubo wrote:
> On 08/02/2011 09:32 AM, liubo wrote:
>> On 08/02/2011 12:11 AM, Josef Bacik wrote:
>>> We always look for delalloc bytes in our io_tree so we can fill in delalloc.
>>> This is fine in most cases, but if we're writing out the btree_inode this is
>>> just a superfluous tree search on the io_tree, and if we have a lot of metadata
>>> dirty this could be an expensive check. So instead check to see if our io_tree
>>> has a ->fill_delalloc op, and if not don't even bother doing the lookup.
>>> Thanks,
>>>
>>> Signed-off-by: Josef Bacik <josef@redhat.com>
>>> ---
>>
>
> sorry, I mixed the patch with others...
>
> The patch is ok.
>
Good because I was horribly confused for a moment :),
Josef
prev parent reply other threads:[~2011-08-02 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 16:11 [PATCH] Btrfs: skip looking for delalloc if we don't have ->fill_delalloc Josef Bacik
2011-08-02 1:32 ` liubo
2011-08-02 1:43 ` liubo
2011-08-02 12:24 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E37EC9A.20908@redhat.com \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.