From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabor Juhos Date: Tue, 02 Aug 2011 18:11:26 +0200 Subject: [ath9k-devel] eeprom txGainType overridden if minor version < 19 In-Reply-To: References: <201108021028.21637.lindner_marek@yahoo.de> <201108021248.35897.lindner_marek@yahoo.de> <201108021637.10859.lindner_marek@yahoo.de> Message-ID: <4E3821AE.7050902@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org 2011.08.02. 17:37 keltez?ssel, Mohammed Shafi ?rta: > On Tue, Aug 2, 2011 at 8:36 PM, Mohammed Shafi wrote: >> On Tue, Aug 2, 2011 at 8:07 PM, Marek Lindner wrote: >>> On Tuesday, August 02, 2011 13:13:27 Adrian Chadd wrote: >>>> Right, so it's an embedded board inside a wireless router? Which router? :) >>> >>> The OM2P but how is this going to help ? I have the feeling we are not getting >>> closer to answer my question: Why does ath9k_hw_4k_get_eeprom() requires the >>> minor version 19 or above before even considering to read the eeprom value ? >>> Can I propose a patch that removes that check ? I already have that patch >>> working for me - just wanted to be sure it does no harm. >> >> hi, >> >> yes, looks like the check should not be there for common, but I don't >> know for what reason the developer made it as a common check. let me >> check it out. please wait. does any one has any comments. can you >> please share what is the issue you are issuing > > > adding the people who made those changes, I am also unable to > understand. verified with the internal code base, the check was not > there. I had no access to the internal code base when I have added that code, so i was unable to verify that the version check is required or not for the 4K EEPROMs. To be on the safe side, I have used the same check which was present in the generic eeprom code. -Gabor