From: Anthony Liguori <aliguori@us.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Luiz Capitulino <lcapitulino@gmail.com>,
TeLeMan <geleman@gmail.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib
Date: Tue, 02 Aug 2011 14:18:17 -0500 [thread overview]
Message-ID: <4E384D79.5070707@us.ibm.com> (raw)
In-Reply-To: <20110802160602.2a22445b@doriath>
On 08/02/2011 02:06 PM, Luiz Capitulino wrote:
> On Tue, 2 Aug 2011 10:03:30 +0800
> TeLeMan<geleman@gmail.com> wrote:
>
>> This patch introduces "-mms-bitfields" cflag on MinGW but this cflag
>> breaks gcc packed structures("__attribute__((packed))"). For example,
>> slirp does not work on Win32.
>
> I'm not familiar with MinGW (or why glib would require that flag).
>
> Michael, Anthony, any idea?
ms-bitfields does packing of bitfields in a way compatible with MSVC.
In order to call Windows API functions that use structures that have
bitfields, you need to use ms-bitfields.
Slirp will need to be fixed to not depend on GCC bitfield layout. This
is one of the reasons why portable code should never use bitfields.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-08-02 19:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 20:00 [Qemu-devel] [PULL 0/25]: QMP queue Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 01/25] QMP: add snapshot-blkdev-sync command Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 02/25] Introduce compiler.h header file Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 03/25] Error: Fix build when qemu-common.h is not included Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib Luiz Capitulino
2011-08-02 2:03 ` TeLeMan
2011-08-02 19:06 ` Luiz Capitulino
2011-08-02 19:18 ` Anthony Liguori [this message]
2011-07-21 20:00 ` [Qemu-devel] [PATCH 05/25] qlist: add qlist_first()/qlist_next() Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 06/25] qapi: add module init types for qapi Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 07/25] qapi: add QAPI visitor core Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 08/25] qapi: add QMP input visitor Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 09/25] qapi: add QMP output visitor Luiz Capitulino
2011-07-21 20:00 ` [Qemu-devel] [PATCH 10/25] qapi: add QAPI dealloc visitor Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 11/25] qapi: add QMP command registration/lookup functions Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 12/25] qapi: add QMP dispatch functions Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 13/25] qapi: add ordereddict.py helper library Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 14/25] qapi: add qapi.py helper libraries Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 15/25] qapi: add qapi-types.py code generator Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 16/25] qapi: add qapi-visit.py " Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 17/25] qapi: add qapi-commands.py " Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 18/25] qapi: test schema used for unit tests Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 19/25] qapi: add test-visitor, tests for gen. visitor code Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 20/25] qapi: add test-qmp-commands, tests for gen. marshalling/dispatch code Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 21/25] qapi: add QAPI code generation documentation Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 22/25] qerror: add QERR_JSON_PARSE_ERROR to qerror.c Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 23/25] guest agent: command state class Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 24/25] guest agent: qemu-ga daemon Luiz Capitulino
2011-07-21 20:01 ` [Qemu-devel] [PATCH 25/25] guest agent: add guest agent RPCs/commands Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2011-07-26 8:59 [PATCH v2 0/1] The intro for QEMU disk I/O limits Zhi Yong Wu
2011-07-26 8:59 ` [PATCH v2 1/1] The codes V2 " Zhi Yong Wu
2011-07-26 19:26 ` Marcelo Tosatti
2011-07-26 21:51 ` [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib Yoder Stuart-B08248
2011-07-26 22:09 ` Anthony Liguori
2011-07-27 8:54 ` Benjamin Herrenschmidt
2011-07-27 13:31 ` David Gibson
2011-07-27 13:13 ` Yoder Stuart-B08248
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E384D79.5070707@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=geleman@gmail.com \
--cc=lcapitulino@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.