From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMpE-0006L8-Hr for qemu-devel@nongnu.org; Tue, 02 Aug 2011 17:48:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoMpD-0001FD-L3 for qemu-devel@nongnu.org; Tue, 02 Aug 2011 17:48:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoMpD-0001F0-E1 for qemu-devel@nongnu.org; Tue, 02 Aug 2011 17:48:31 -0400 Message-ID: <4E3870A8.308@redhat.com> Date: Wed, 03 Aug 2011 00:48:24 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E381EA7.2070809@redhat.com> <4E383C55.5050703@redhat.com> <4E38647F.3010509@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] modelling omap_gpmc with the hierarchical memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 08/03/2011 12:28 AM, Peter Maydell wrote: > On 2 August 2011 21:56, Anthony Liguori wrote: > > Hrm, this looks like badness to me. > > > > You're effectively using MemoryRegions to implement an ad-hoc interface. > > As you'll see below, the hardware intreface is somewhat ad-hoc :-) > IMO it fits perfectly into a qdev which contains 8 qbuses, each of which is connected to another qdev. The plan would be: - fold sysbus into qdev - improve qdev/qbus memory region support - reimplement PCI BARs atop qdev regions -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.