From: Bill Kendall <wkendall@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API
Date: Wed, 03 Aug 2011 07:07:52 -0500 [thread overview]
Message-ID: <4E393A18.1050607@sgi.com> (raw)
In-Reply-To: <20110803120245.GA25335@infradead.org>
Christoph Hellwig wrote:
> On Wed, Aug 03, 2011 at 06:57:37AM -0500, Bill Kendall wrote:
>> Christoph Hellwig wrote:
>>> Bill,
>>>
>>> one thing I noticed looking over the code to understand your changes
>>> is that there still is a lot of dead code in xfsdump. One that
>>> has a lot of implications and seems fairly useless for any non-IRIX
>>> version is the miniroot mode. Any chance we can rip that out? There's
>> Yes, that's being used to disable multi-stream code in the Linux version.
>> The end of my multi-stream patch series removes the miniroot code.
>
> Ooops, I didn't notice miniroot is actually defined to true. Now that
> I look deeper that also answers my comment about the duplicate signal
> setup in main - one it's done for the miniroot case, and once for the
> !miniroot case.
>
> Now that we uses EPIPE instead of SIGPIPE is there actually any good
> reason to do this setup in two different places?
Nope, I'll resubmit with this change.
Bill
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-08-03 12:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 20:40 [PATCH 0/4] xfsdump: convert to using the POSIX signal API Bill Kendall
2011-07-29 20:40 ` [PATCH 1/4] xfsdump: remove conditional OPENMASKED code Bill Kendall
2011-08-02 10:13 ` Christoph Hellwig
2011-08-02 14:07 ` Bill Kendall
2011-07-29 20:40 ` [PATCH 2/4] xfsdump: process EPIPE instead of catching SIGPIPE Bill Kendall
2011-08-02 10:15 ` Christoph Hellwig
2011-07-29 20:40 ` [PATCH 3/4] xfsdump: remove SIGCHLD handling Bill Kendall
2011-08-02 10:22 ` Christoph Hellwig
2011-08-02 14:13 ` Bill Kendall
2011-07-29 20:40 ` [PATCH 4/4] xfsdump: convert to the POSIX signal API Bill Kendall
2011-08-03 10:48 ` Christoph Hellwig
2011-08-03 10:56 ` Christoph Hellwig
2011-08-03 12:11 ` Bill Kendall
2011-08-03 12:39 ` Christoph Hellwig
2011-08-03 19:28 ` Bill Kendall
2011-08-04 7:53 ` Christoph Hellwig
2011-08-04 12:35 ` Bill Kendall
2011-08-04 12:37 ` Christoph Hellwig
2011-08-03 10:59 ` [PATCH 0/4] xfsdump: convert to using " Christoph Hellwig
2011-08-03 11:57 ` Bill Kendall
2011-08-03 12:02 ` Christoph Hellwig
2011-08-03 12:07 ` Bill Kendall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E393A18.1050607@sgi.com \
--to=wkendall@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.