From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QobP7-0002vj-9L for qemu-devel@nongnu.org; Wed, 03 Aug 2011 09:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QobP6-0004i8-37 for qemu-devel@nongnu.org; Wed, 03 Aug 2011 09:22:33 -0400 Received: from david.siemens.de ([192.35.17.14]:17346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QobP5-0004i0-OE for qemu-devel@nongnu.org; Wed, 03 Aug 2011 09:22:32 -0400 Message-ID: <4E394B91.90301@siemens.com> Date: Wed, 03 Aug 2011 15:22:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20110719115511.609C553E5@gandalf.tls.msk.ru> <4E25FBA6.3060803@web.de> <20110720163450.GA17333@amt.cnet> <4E275169.9070402@web.de> <4E38FAE3.8070408@msgid.tls.msk.ru> In-Reply-To: <4E38FAE3.8070408@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Marcelo Tosatti , qemu-devel@nongnu.org On 2011-08-03 09:38, Michael Tokarev wrote: > So, can we decide on this somehow? I don't see a code > path where we don't call monitor_resume at the end, > so the "intermediate" monitor_resume can be dropped. > This way we fix real bug. If there will be other > problem from that, it can be fixed later - this will > mean that code path is found... I do not see any reason for the spurious resume as well, so you may add my Reviewed-by: Jan Kiszka > > Should I resend the initial patch again? May help to finally trigger the merge. Direct it to Luiz Capitulino as the subsystem maintainer. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux