From: Steve Dickson <SteveD@redhat.com>
To: Matthew Treinish <treinish@linux.vnet.ibm.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] mountd: Fixed strcmp usage in in insert groups.
Date: Wed, 03 Aug 2011 13:45:42 -0400 [thread overview]
Message-ID: <4E398946.4080405@RedHat.com> (raw)
In-Reply-To: <1312225347-11282-1-git-send-email-treinish@linux.vnet.ibm.com>
On 08/01/2011 03:02 PM, Matthew Treinish wrote:
> Fixed the usage of strcmp in the duplicate check in insert groups. Fixes an
> issue with showmount and other commands that required the group information.
>
> Signed-off-by: Matthew Treinish <treinish@linux.vnet.ibm.com>
Committed...
steved.
> ---
> utils/mountd/mountd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
> index 035624c..bcf5080 100644
> --- a/utils/mountd/mountd.c
> +++ b/utils/mountd/mountd.c
> @@ -633,7 +633,7 @@ static void insert_group(struct exportnode *e, char *newname)
> struct groupnode *g;
>
> for (g = e->ex_groups; g; g = g->gr_next)
> - if (strcmp(g->gr_name, newname))
> + if (!strcmp(g->gr_name, newname))
> return;
>
> g = xmalloc(sizeof(*g));
prev parent reply other threads:[~2011-08-03 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 19:02 [PATCH 1/2] mountd: Fixed strcmp usage in in insert groups Matthew Treinish
2011-08-01 19:02 ` [PATCH 2/2] mountd: Removed duplicate check from insert_groups Matthew Treinish
2011-08-03 17:46 ` Steve Dickson
2011-08-03 17:45 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E398946.4080405@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=treinish@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.