From: Phillip Susi <psusi@cfl.rr.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ayan George <ayan@ayan.net>, linux-kernel@vger.kernel.org
Subject: Re: loop device auto release patch
Date: Wed, 03 Aug 2011 21:58:24 -0400 [thread overview]
Message-ID: <4E39FCC0.4000800@cfl.rr.com> (raw)
In-Reply-To: <20110715121903.dc543613.akpm@linux-foundation.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/15/2011 03:19 PM, Andrew Morton wrote:
> The patch appears to do two unrelated things. That's generally frowned
> upon, but doesn't bother me much if the patch is small.
>
> Still, splitting it into two patches (in which the bugfix is staged
> first) would be advantageous for people who might wish to backport the
> fix into earlier kernels.
It looks like this got stalled and someone emailed me asking what
happened to it. I'm not sure that splitting the patch in two makes
sense. I don't see how it does two unrelated things. The uevent
problem was caused by the argument being NULL. This patch just removes
the argument since it is entirely unnecessary. Given that the argument
is gone and can no longer be passed as NULL, the tests for NULL are
rendered moot, and so removing them seems quite related. I suppose you
could do the first and not the second, but then you would be leaving
cruft behind.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk45/MAACgkQJ4UciIs+XuL7+gCfUA8TpE2SRRCo+/VzRJMCrwg6
OEsAmwWphcaIF/wdguyHch6gEizv1Tjb
=pGGG
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-08-04 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E1F3BE0.8040506@ayan.net>
2011-07-15 19:12 ` loop device auto release patch Phillip Susi
2011-07-15 19:19 ` Andrew Morton
2011-07-15 22:28 ` Ayan George
2011-08-04 1:58 ` Phillip Susi [this message]
2011-08-04 2:06 ` Andrew Morton
2011-08-04 2:13 ` Ayan George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E39FCC0.4000800@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=akpm@linux-foundation.org \
--cc=ayan@ayan.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.