From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh kumar Subject: Re: spi/spi-pl022: Query on working of DMA mode Date: Thu, 4 Aug 2011 09:09:39 +0530 Message-ID: <4E3A147B.9060305@st.com> References: <4E3931B7.3010400@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Linus WALLEIJ , Armando VISCONTI , Shiraz HASHIM , viresh kumar , "spi-devel-general@lists.sourceforge.net" , "linux-arm-kernel@lists.infradead.org" To: Linus Walleij Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 08/03/2011 08:28 PM, Linus Walleij wrote: >> > Here, allocation is requested with GFP_KERNEL flag, from a tasklet. >> > Which gives following crash logs: > What happens if you replace it with GFP_NOWAIT? > > That should work for everybody. > > Or you could remove the tasklet allover and replace it with a workqueue. > Ok. I will fix this and include in my patchset. >> > Is DMA mode working in your case? > Yes, magically :-/ But how? Don't you have any message with more than one transfer in it? -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Thu, 4 Aug 2011 09:09:39 +0530 Subject: spi/spi-pl022: Query on working of DMA mode In-Reply-To: References: <4E3931B7.3010400@st.com> Message-ID: <4E3A147B.9060305@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/03/2011 08:28 PM, Linus Walleij wrote: >> > Here, allocation is requested with GFP_KERNEL flag, from a tasklet. >> > Which gives following crash logs: > What happens if you replace it with GFP_NOWAIT? > > That should work for everybody. > > Or you could remove the tasklet allover and replace it with a workqueue. > Ok. I will fix this and include in my patchset. >> > Is DMA mode working in your case? > Yes, magically :-/ But how? Don't you have any message with more than one transfer in it? -- viresh