From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QorBN-0008PO-Nu for qemu-devel@nongnu.org; Thu, 04 Aug 2011 02:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QorBM-0006aH-JD for qemu-devel@nongnu.org; Thu, 04 Aug 2011 02:13:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45125 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QorBM-0006a6-EX for qemu-devel@nongnu.org; Thu, 04 Aug 2011 02:13:24 -0400 Message-ID: <4E3A3883.9070002@suse.de> Date: Thu, 04 Aug 2011 08:13:23 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-13-git-send-email-armbru@redhat.com> In-Reply-To: <1312376904-16115-13-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 12/45] scsi-disk: Track tray open/close state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com, hch@lst.de On 08/03/2011 03:07 PM, Markus Armbruster wrote: > We already track it in BlockDriverState since commit 4be9762a. As > discussed in that commit's message, we should track it in the device > device models instead, because it's device state. > > Signed-off-by: Markus Armbruster > --- > hw/scsi-disk.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index d549cb7..2d5e157 100644 > --- a/hw/scsi-disk.c > +++ b/hw/scsi-disk.c > @@ -72,6 +72,7 @@ struct SCSIDiskState > char *version; > char *serial; > SCSISense sense; > + bool tray_open; > }; > > static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type); > @@ -829,6 +830,7 @@ static void scsi_disk_emulate_start_stop(SCSIDiskRe= q *r) > > if (s->qdev.type =3D=3D TYPE_ROM&& loej) { > bdrv_eject(s->bs, !start); > + s->tray_open =3D !start; > } > } > Acked-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)