From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpJFB-00059g-7q for qemu-devel@nongnu.org; Fri, 05 Aug 2011 08:11:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpJF7-00083n-4s for qemu-devel@nongnu.org; Fri, 05 Aug 2011 08:11:13 -0400 Received: from lo.gmane.org ([80.91.229.12]:55140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpJF6-00083i-W5 for qemu-devel@nongnu.org; Fri, 05 Aug 2011 08:11:09 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QpJF1-0000Es-9z for qemu-devel@nongnu.org; Fri, 05 Aug 2011 14:11:03 +0200 Received: from 213.33.220.118 ([213.33.220.118]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Aug 2011 14:11:03 +0200 Received: from e.voevodin by 213.33.220.118 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Aug 2011 14:11:03 +0200 From: Evgeny Voevodin Date: Fri, 05 Aug 2011 16:10:49 +0400 Message-ID: <4E3BDDC9.9040601@samsung.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] target-arm: upgrade for secondary cpu bootloader List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kyungmin Park , Dmitry Solodkiy On 08/05/2011 03:35 PM, Peter Maydell wrote: > On 5 August 2011 11:37, Evgeny Voevodin wrote: >> Secondary CPU bootloader enables interrupt and issues wfi until start >> address is written to system controller. The position where to find this >> start address is hardcoded to 0x10000030. This commit adds new bootloader >> for secondary CPU which allows a target board to cpecify a position where to >> find start address. > > What's the motivation for this? (ie what target board needs this?) The motivation is that Samsung s5pc210 board which is under development needs this. Also, I believe that more boards will need it in future. > (Is there a patch 2/2 or is the subject wrong?) Subject is wrong. > > Also, having a second almost-but-not-quite-identical copy of the > secondary-cpu bootloader is definitely the wrong approach. If some > boards need this then we should just have a single smpboot[] bootloader > which has both privbase and startaddr specified as data members, and > just have the code which sets it up fill in 0x10000030 if the board > doesn't override the default. > > -- PMM > > Will update.