From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 13/39] rtl8139: convert to memory API
Date: Sun, 07 Aug 2011 11:56:30 +0300
Message-ID: <4E3E533E.2060402@redhat.com>
References: <1312463195-13605-1-git-send-email-avi@redhat.com> <1312463195-13605-14-git-send-email-avi@redhat.com> <4E3BFC6C.7010403@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:16892 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751556Ab1HGI4g (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 7 Aug 2011 04:56:36 -0400
In-Reply-To: <4E3BFC6C.7010403@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/05/2011 05:21 PM, Anthony Liguori wrote:
>> +    { 0, 0x100, 4, .write = rtl8139_ioport_writel, },
>> +    PORTIO_END
>
>
> Hrm, I missed this #define when it was introduced.
>
> Elsewhere we use:
>
> VMSTATE_END_OF_LIST()
> DEFINE_PROP_END_OF_LIST()
>
> For consistency, we ought to use PORTIO_END_OF_LIST()

Okay, fixed.

-- 
error compiling committee.c: too many arguments to function