All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Disable guest_agent for mingw32
Date: Sun, 07 Aug 2011 10:50:47 -0500	[thread overview]
Message-ID: <4E3EB457.6060202@codemonkey.ws> (raw)
In-Reply-To: <1312663642-8298-1-git-send-email-weil@mail.berlios.de>

On 08/06/2011 03:47 PM, Stefan Weil wrote:
> guest_agent is not supported for mingw32, so the default value
> should be 'no', not 'yes'.

Why is it not supported?  It should build just fine.

If the answer is, -mms-bitfield, then we should fix slirp instead of 
disabling guest-agent.

Regards,

Anthony Liguori

>
> This removes the dependencies to glib-2.0 and python which
> makes native and cross builds for w32 much easier (no need
> to get and install these extra packages).
>
> It also avoids the problems caused by different bitfield alignment
> which is required by glib-2.0.
>
> It is still possible to set guest_agent=yes via configure option.
>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
>   configure |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 0c67a4a..4cb33d9 100755
> --- a/configure
> +++ b/configure
> @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then
>     bindir="\${prefix}"
>     sysconfdir="\${prefix}"
>     confsuffix=""
> +  guest_agent="no"
>   fi
>
>   werror=""

  parent reply	other threads:[~2011-08-07 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-06 20:47 [Qemu-devel] [PATCH] configure: Disable guest_agent for mingw32 Stefan Weil
2011-08-07 10:25 ` Stefan Weil
2011-08-07 15:50 ` Anthony Liguori [this message]
2011-08-07 16:41   ` Stefan Weil
2011-08-08 19:17 ` Anthony Liguori
2011-08-12 13:47 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3EB457.6060202@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.