From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types
Date: Mon, 08 Aug 2011 08:00:06 -0500 [thread overview]
Message-ID: <4E3FDDD6.9070501@codemonkey.ws> (raw)
In-Reply-To: <1312808190-31074-1-git-send-email-avi@redhat.com>
On 08/08/2011 07:56 AM, Avi Kivity wrote:
> QEMU deals with a lot of fixed width integer types; their names
> (uint64_t etc) are clumsy to use and take up a lot of space.
>
> Following Linux, introduce shorter names, for example U64 for
> uint64_t.
Except Linux uses lower case letters.
I personally think Linux style is wrong here. The int8_t types are
standard types.
Besides, we save lots of characters by using 4-space tabs instead of
8-space tabs. We can afford to spend some of those saved characters on
using proper type names :-)
Regards,
Anthony Liguori
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
> qemu-common.h | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index 0fdecf1..52a2300 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -112,6 +112,15 @@ static inline char *realpath(const char *path, char *resolved_path)
> int qemu_main(int argc, char **argv, char **envp);
> #endif
>
> +typedef int8_t S8;
> +typedef uint8_t U8;
> +typedef int16_t S16;
> +typedef uint16_t U16;
> +typedef int32_t S32;
> +typedef uint32_t U32;
> +typedef int64_t S64;
> +typedef uint64_t U64;
> +
> /* bottom halves */
> typedef void QEMUBHFunc(void *opaque);
>
next prev parent reply other threads:[~2011-08-08 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 12:56 [PATCH] Introduce short names for fixed width integer types Avi Kivity
2011-08-08 12:56 ` [Qemu-devel] " Avi Kivity
2011-08-08 13:00 ` Anthony Liguori [this message]
2011-08-08 13:12 ` Avi Kivity
2011-08-08 13:17 ` Anthony Liguori
2011-08-08 13:19 ` Avi Kivity
2011-08-08 13:19 ` [Qemu-devel] " Avi Kivity
2011-08-08 14:17 ` Kevin Wolf
2011-08-08 14:17 ` Kevin Wolf
2011-08-08 13:19 ` Peter Maydell
2011-08-09 10:18 ` malc
2011-08-09 10:18 ` malc
2011-08-09 12:39 ` Juan Quintela
2011-08-09 12:39 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3FDDD6.9070501@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.