From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types Date: Mon, 08 Aug 2011 08:17:03 -0500 Message-ID: <4E3FE1CF.2010203@codemonkey.ws> References: <1312808190-31074-1-git-send-email-avi@redhat.com> <4E3FDDD6.9070501@codemonkey.ws> <4E3FE0B7.3090805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:41595 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245Ab1HHNRH (ORCPT ); Mon, 8 Aug 2011 09:17:07 -0400 Received: by ywf7 with SMTP id 7so188574ywf.19 for ; Mon, 08 Aug 2011 06:17:06 -0700 (PDT) In-Reply-To: <4E3FE0B7.3090805@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/08/2011 08:12 AM, Avi Kivity wrote: > On 08/08/2011 04:00 PM, Anthony Liguori wrote: >> On 08/08/2011 07:56 AM, Avi Kivity wrote: >>> QEMU deals with a lot of fixed width integer types; their names >>> (uint64_t etc) are clumsy to use and take up a lot of space. >>> >>> Following Linux, introduce shorter names, for example U64 for >>> uint64_t. >> >> Except Linux uses lower case letters. >> >> I personally think Linux style is wrong here. The int8_t types are >> standard types. >> >> Besides, we save lots of characters by using 4-space tabs instead of >> 8-space tabs. We can afford to spend some of those saved characters on >> using proper type names :-) >> > > It's not about saving space, it's about improving readability. We have > about 21k uses of these types, they deserve short names. This is one of the few areas that we're actually consistent with today. Introducing a new set of types will just create inconsistency. Most importantly, these are standard types. Every modern library and C program should be using them. TBH, having short names is just a bad case of NIH. Regards, Anthony Liguori