From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@amd64.org>
Cc: X86-ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [RFC][PATCH 2/2] x86, cpu, amd: Add a per-vendor BSP function
Date: Mon, 08 Aug 2011 15:56:08 -0500 [thread overview]
Message-ID: <4E404D68.5060507@zytor.com> (raw)
In-Reply-To: <1312829872-20260-3-git-send-email-bp@amd64.org>
On 08/08/2011 01:57 PM, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Add a per-vendor function which runs everything that needs to run once
> on the BSP during boot. Concentrate AMD-specific functionality there.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
>
> +static void __init vendor_run_on_bsp(struct cpuinfo_x86 *c)
> +{
> + switch (c->x86_vendor) {
> + case X86_VENDOR_AMD:
> + amd_run_on_bsp(c);
> + break;
> +
> + default:
> + break;
> + }
> +}
> +
This is totally going backwards. We *should* be using struct cpu_dev
rather than switch statements for this.
-hpa
next prev parent reply other threads:[~2011-08-08 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 18:57 [RFC][PATCH 0/2] x86, CPU: Run stuff on the BSP Borislav Petkov
2011-08-08 18:57 ` [RFC][PATCH 1/2] x86, CPU: Drop second get_cpu_cap prototype Borislav Petkov
2011-08-08 18:57 ` [RFC][PATCH 2/2] x86, cpu, amd: Add a per-vendor BSP function Borislav Petkov
2011-08-08 20:56 ` H. Peter Anvin [this message]
2011-08-08 21:57 ` Borislav Petkov
2011-08-08 22:13 ` H. Peter Anvin
2011-08-09 13:05 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E404D68.5060507@zytor.com \
--to=hpa@zytor.com \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.