From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v4 02/10] ARM: KVM: Hypervisor identity mapping Date: Tue, 09 Aug 2011 12:20:27 +0300 Message-ID: <4E40FBDB.1040505@redhat.com> References: <20110806103821.27198.41231.stgit@localhost6.localdomain6> <20110806103910.27198.11538.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, catalin.marinas@arm.com, tech@virtualopensystems.com, android-virt@lists.cs.columbia.edu To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37563 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425Ab1HIJUv (ORCPT ); Tue, 9 Aug 2011 05:20:51 -0400 In-Reply-To: <20110806103910.27198.11538.stgit@localhost6.localdomain6> Sender: kvm-owner@vger.kernel.org List-ID: On 08/06/2011 01:39 PM, Christoffer Dall wrote: > Adds support in the identity mapping feature that allows KVM to setup > identity mapping for the Hyp mode with the AP[1] bit set as required by > the specification and also supports freeing created sub pmd's after > finished use. > > These two functions: > - hyp_identity_mapping_add(pgd, addr, end); > - hyp_identity_mapping_del(pgd, addr, end); > are essentially calls the same function as the non-hyp versions but > with a different argument value. KVM calls these functions to setup > and teardown the identity mapping used to initialize the hypervisor. > > Note, the hyp-version of the _del function actually frees the pmd's > pointed to by the pgd as opposed to the non-hyp version which just > clears them. > > These are for mapping host memory, not guest memory, right? -- error compiling committee.c: too many arguments to function