From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API Date: Tue, 09 Aug 2011 12:26:18 +0300 Message-ID: <4E40FD3A.70208@redhat.com> References: <4E40F628.9050505@redhat.com> <1312880570-12530-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Peter Maydell Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 08/09/2011 12:23 PM, Peter Maydell wrote: > On 9 August 2011 10:02, Avi Kivity wrote: > > +static const MemoryRegionOps omap_gpmc_ops = { > > + .read = omap_gpmc_read, > > + .write = omap_gpmc_write, > > + .endianness = DEVICE_NATIVE_ENDIAN, > > + .valid = { > > + .min_access_size = 4, > > + .max_access_size = 4, > > + }, > > }; > > Does this give debug trace output for missized accesses? Only after we implement and configure a debug policy in memory.c > That's the main point of the badread/badwrite functions... These are broken now, aren't they? -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqiZs-000808-Jx for qemu-devel@nongnu.org; Tue, 09 Aug 2011 05:26:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QqiZr-0003Xm-Qs for qemu-devel@nongnu.org; Tue, 09 Aug 2011 05:26:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QqiZr-0003XS-KR for qemu-devel@nongnu.org; Tue, 09 Aug 2011 05:26:23 -0400 Message-ID: <4E40FD3A.70208@redhat.com> Date: Tue, 09 Aug 2011 12:26:18 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E40F628.9050505@redhat.com> <1312880570-12530-1-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 08/09/2011 12:23 PM, Peter Maydell wrote: > On 9 August 2011 10:02, Avi Kivity wrote: > > +static const MemoryRegionOps omap_gpmc_ops = { > > + .read = omap_gpmc_read, > > + .write = omap_gpmc_write, > > + .endianness = DEVICE_NATIVE_ENDIAN, > > + .valid = { > > + .min_access_size = 4, > > + .max_access_size = 4, > > + }, > > }; > > Does this give debug trace output for missized accesses? Only after we implement and configure a debug policy in memory.c > That's the main point of the badread/badwrite functions... These are broken now, aren't they? -- error compiling committee.c: too many arguments to function