From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH v1.1 09/24] omap_gpmc/nseries/tusb6010: convert to memory API Date: Tue, 09 Aug 2011 15:56:26 +0300 Message-ID: <4E412E7A.6000607@redhat.com> References: <4E40F628.9050505@redhat.com> <1312880570-12530-1-git-send-email-avi@redhat.com> <4E40FD3A.70208@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Peter Maydell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9576 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036Ab1HIM4i (ORCPT ); Tue, 9 Aug 2011 08:56:38 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/09/2011 12:41 PM, Peter Maydell wrote: > On 9 August 2011 10:26, Avi Kivity wrote: > > On 08/09/2011 12:23 PM, Peter Maydell wrote: > >> > >> On 9 August 2011 10:02, Avi Kivity wrote: > >> > +static const MemoryRegionOps omap_gpmc_ops = { > >> > + .read = omap_gpmc_read, > >> > + .write = omap_gpmc_write, > >> > + .endianness = DEVICE_NATIVE_ENDIAN, > >> > + .valid = { > >> > + .min_access_size = 4, > >> > + .max_access_size = 4, > >> > + }, > >> > }; > >> > >> Does this give debug trace output for missized accesses? > > > > Only after we implement and configure a debug policy in memory.c > > > >> That's the main point of the badread/badwrite functions... > > > > These are broken now, aren't they? > > They successfully print a message, which as I say is the > main point. The OMAP TRM typically says the behaviour isn't > defined for wrong-size accesses, so guest code doing it is > broken anyhow and so the error in the current implementation > is IMHO not so serious. > > I think if (as here) it turns out that we need more functionality > in memory.c then we should be implementing it, not silently > dropping things in the conversion process. > Okay. I'll update the patch to forward to the badread/badwrite functions on bad size. -- error compiling committee.c: too many arguments to function