Re: [RFC 2/2] mac80211: config hw when going back on-channel

[Ben Greear <greearb@candelatech.com>]

On 08/09/2011 06:28 AM, Johannes Berg wrote:
> On Tue, 2011-08-09 at 06:27 -0700, Ben Greear wrote:
>> On 08/09/2011 05:14 AM, Johannes Berg wrote:
>>> On Mon, 2011-07-25 at 10:18 -0700, Ben Greear wrote:
>>>> On 07/25/2011 08:29 AM, Eliad Peller wrote:
>>>>> The hw is currently not configured when going
>>>>> back on-channel.
>>>>
>>>> I am less sure about this patch.  With the existing code,
>>>> I think it should catch going from on channel to off
>>>> and do the hw config properly.
>>>>
>>>> With your change it will also reconfig the hardware, but it will
>>>> reconfig even if we were already on-channel (if, for instance,
>>>> local->tmp_channel is oper-channel), right?
>>>
>>> I think even if we're already on the same channel, we might still have
>>> the off-channel flag (IEEE80211_CONF_OFFCHANNEL) set? So the patch might
>>> still be needed to clear that?
>>
>> Well, maybe so, but if we are not off-channel and still have the off-channel
>> flag set, that would seem to be another bug.
>
> Hm, true. Not sure about this then.

When I was looking at his patches, I eventually thought that it was better
than current code, but I think it might still have some room for improvement
because I think it could, in some cases, cause a re-config when not needed.

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com