All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Pascal Obry <pascal@obry.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] On Cygwin support both UNIX and DOS style path-names
Date: Tue, 09 Aug 2011 21:47:15 +0200	[thread overview]
Message-ID: <4E418EC3.4070904@kdbg.org> (raw)
In-Reply-To: <1312560614-20772-3-git-send-email-pascal@obry.net>

Am 05.08.2011 18:10, schrieb Pascal Obry:
> In fact Cygwin supports both, so make Git agree with this.
> The failing case is when a file is committed in a sub-dir of the
> repository using a log message from a file specified with a DOS
> style path-name. To reproduce:
> 
>    $ cd src
>    $ git commit -F c:\tmp\log.txt file.c
>    fatal: could not read log file 'src/c:\tmp\log.txt': No such file \
>    or directory.

Do you also want to support this:

     $ git add src\file.c

i.e., backslash in pathspec? Then you need more than this:

> +#define has_dos_drive_prefix(path) (isalpha(*(path)) && (path)[1] == ':')
> +#define is_dir_sep(c) ((c) == '/' || (c) == '\\')

In particular, you have to enable backslash processing in
setup.c:prefix_filename(), but then you lose the ability to escape
special characters with the backslash.

-- Hannes

      parent reply	other threads:[~2011-08-09 19:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 16:10 [PATH 0/2] On Cygwin support both UNIX and DOS style path-names Pascal Obry
2011-08-05 16:10 ` [PATCH 1/2] git-compat-util: add generic find_last_dir_sep that respects is_dir_sep Pascal Obry
2011-08-05 16:10 ` [PATCH 2/2] On Cygwin support both UNIX and DOS style path-names Pascal Obry
2011-08-05 17:29   ` Erik Faye-Lund
2011-08-05 17:35     ` Pascal Obry
2011-08-05 17:39       ` Erik Faye-Lund
2011-08-05 17:51         ` Erik Faye-Lund
2011-08-05 18:39         ` Pascal Obry
2011-08-09 17:30       ` Ramsay Jones
2011-08-09 17:26     ` Ramsay Jones
2011-08-05 17:48   ` Junio C Hamano
2011-08-05 17:58     ` Erik Faye-Lund
2011-08-06  7:01     ` Pascal Obry
2011-08-09 17:24   ` Ramsay Jones
2011-08-09 20:38     ` Pascal Obry
2011-08-11 20:35       ` Ramsay Jones
2011-08-13 17:34         ` Pascal Obry
2011-08-10  2:44     ` Vijay Lakshminarayanan
2011-08-09 19:47   ` Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E418EC3.4070904@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=pascal@obry.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.