All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] ui/spice-core: report version in 'info spice'
Date: Wed, 10 Aug 2011 10:10:59 +0200	[thread overview]
Message-ID: <4E423D13.70106@redhat.com> (raw)
In-Reply-To: <20110810074329.GE5637@bow.redhat.com>

   Hi,

>> I think it would also be nice to somehow hint this is the spice
> sent a second patch (fixing the above), but didn't do any hinting. I'll send a third.

Saw v2.  I would just stick a "version" string into the dict instead of 
the three values for major, minor and micro.

>> version qemu was compiled against.  The shared library which is
>> actually used might be newer.
>
> I thought of this problem but decided it's better to at least have the compiled
> version (getting the linked against version is not hard, but I'd rather
> not force to do it at this moment - I guess via dlopen. Which is linux specific -
> will need yet another wrapper for that api to compile on windows).

The compiled version is perfectly fine, I think it is more useful to 
have that one as it decides which features qemu is able to use.

If we want report the runtime version too (any reason to do this?) I'd 
just add a spice_server_get_version() function to the library.

cheers,
   Gerd

  reply	other threads:[~2011-08-10  8:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 20:53 [Qemu-devel] [PATCH 1/2] qxl: unbreak after memory API conversion Alon Levy
2011-08-09 20:53 ` [Qemu-devel] [PATCH 2/2] ui/spice-core: report version in 'info spice' Alon Levy
2011-08-10  6:54   ` Gerd Hoffmann
2011-08-10  7:43     ` Alon Levy
2011-08-10  8:10       ` Gerd Hoffmann [this message]
2011-08-10  8:32         ` Alon Levy
2011-08-10 15:10           ` Gerd Hoffmann
2011-08-10 15:29 ` [Qemu-devel] [PATCH 1/2] qxl: unbreak after memory API conversion Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E423D13.70106@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.