From: Avi Kivity <avi@redhat.com>
To: Jiri Denemark <jdenemar@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS
Date: Wed, 10 Aug 2011 17:08:42 +0300 [thread overview]
Message-ID: <4E4290EA.4090100@redhat.com> (raw)
In-Reply-To: <20110810140245.GB216233@orkuz.home>
On 08/10/2011 05:02 PM, Jiri Denemark wrote:
> >
> > Shouldn't we use -isystem instead of -I for system headers?
>
> That would be ideal but unfortunately QEMU_CFLAGS also contains output of
> pkg-config --cflags which uses -I for header paths. We would need to convert
> them to -isystem. And is -isystem even portable to other compilers (in case we
> care about that)?
Well, it's really a pkg-config bug. It should check whether -isystem is
supported and use it if so.
> IMHO just moving paths to qemu sources first is easier and the result is the
> same.
>
Agree.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-08-10 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 10:04 [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS Jiri Denemark
2011-08-10 12:46 ` Michael Roth
2011-08-10 13:04 ` Avi Kivity
2011-08-10 14:02 ` Jiri Denemark
2011-08-10 14:08 ` Avi Kivity [this message]
2011-08-12 13:46 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4290EA.4090100@redhat.com \
--to=avi@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.