From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41418)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qr9Si-000835-Je
	for qemu-devel@nongnu.org; Wed, 10 Aug 2011 10:08:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qr9Sh-000190-70
	for qemu-devel@nongnu.org; Wed, 10 Aug 2011 10:08:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62728)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qr9Sg-00018q-OF
	for qemu-devel@nongnu.org; Wed, 10 Aug 2011 10:08:47 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7AE8jGM013888
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 10 Aug 2011 10:08:45 -0400
Message-ID: <4E4290EA.4090100@redhat.com>
Date: Wed, 10 Aug 2011 17:08:42 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <7d7114c0f2ebea6cf24689d9e58e6494d1b8a463.1312970654.git.jdenemar@redhat.com>
	<4E4281CF.2030700@redhat.com> <20110810140245.GB216233@orkuz.home>
In-Reply-To: <20110810140245.GB216233@orkuz.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before
 QEMU_CFLAGS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jiri Denemark <jdenemar@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/10/2011 05:02 PM, Jiri Denemark wrote:
> >
> >  Shouldn't we use -isystem instead of -I for system headers?
>
> That would be ideal but unfortunately QEMU_CFLAGS also contains output of
> pkg-config --cflags which uses -I for header paths. We would need to convert
> them to -isystem. And is -isystem even portable to other compilers (in case we
> care about that)?

Well, it's really a pkg-config bug.  It should check whether -isystem is 
supported and use it if so.

> IMHO just moving paths to qemu sources first is easier and the result is the
> same.
>

Agree.

-- 
error compiling committee.c: too many arguments to function