From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Wed, 10 Aug 2011 14:58:53 +0000 Subject: Re: [PATCH] powerpc/kvm: fix build errors with older toolchains Message-Id: <4E429CAD.5050000@suse.de> List-Id: References: <1312397755-15737-1-git-send-email-nacc@us.ibm.com> In-Reply-To: <1312397755-15737-1-git-send-email-nacc@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nishanth Aravamudan Cc: Benjamin Herrenschmidt , Avi Kivity , Marcelo Tosatti , Paul Mackerras , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote: > On a box with gcc 4.3.2, I see errors like: > > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x Paul, mind to ack? Alex > Signed-off-by: Nishanth Aravamudan > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > index 6dd3358..de29501 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION > reg = 0 > .rept 32 > li r6,reg*16+VCPU_VSRS > - stxvd2x reg,r6,r3 > + STXVD2X(reg,r6,r3) > reg = reg + 1 > .endr > FTR_SECTION_ELSE > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION > reg = 0 > .rept 32 > li r7,reg*16+VCPU_VSRS > - lxvd2x reg,r7,r4 > + LXVD2X(reg,r7,r4) > reg = reg + 1 > .endr > FTR_SECTION_ELSE From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx2.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 3D1FDB6F68 for ; Thu, 11 Aug 2011 00:59:03 +1000 (EST) Message-ID: <4E429CAD.5050000@suse.de> Date: Wed, 10 Aug 2011 16:58:53 +0200 From: Alexander Graf MIME-Version: 1.0 To: Nishanth Aravamudan Subject: Re: [PATCH] powerpc/kvm: fix build errors with older toolchains References: <1312397755-15737-1-git-send-email-nacc@us.ibm.com> In-Reply-To: <1312397755-15737-1-git-send-email-nacc@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: kvm@vger.kernel.org, Marcelo Tosatti , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , Avi Kivity , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote: > On a box with gcc 4.3.2, I see errors like: > > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x Paul, mind to ack? Alex > Signed-off-by: Nishanth Aravamudan > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > index 6dd3358..de29501 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION > reg = 0 > .rept 32 > li r6,reg*16+VCPU_VSRS > - stxvd2x reg,r6,r3 > + STXVD2X(reg,r6,r3) > reg = reg + 1 > .endr > FTR_SECTION_ELSE > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION > reg = 0 > .rept 32 > li r7,reg*16+VCPU_VSRS > - lxvd2x reg,r7,r4 > + LXVD2X(reg,r7,r4) > reg = reg + 1 > .endr > FTR_SECTION_ELSE From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068Ab1HJO7A (ORCPT ); Wed, 10 Aug 2011 10:59:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47175 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922Ab1HJO67 (ORCPT ); Wed, 10 Aug 2011 10:58:59 -0400 Message-ID: <4E429CAD.5050000@suse.de> Date: Wed, 10 Aug 2011 16:58:53 +0200 From: Alexander Graf User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 MIME-Version: 1.0 To: Nishanth Aravamudan Cc: Benjamin Herrenschmidt , Avi Kivity , Marcelo Tosatti , Paul Mackerras , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/kvm: fix build errors with older toolchains References: <1312397755-15737-1-git-send-email-nacc@us.ibm.com> In-Reply-To: <1312397755-15737-1-git-send-email-nacc@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote: > On a box with gcc 4.3.2, I see errors like: > > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x Paul, mind to ack? Alex > Signed-off-by: Nishanth Aravamudan > --- > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > index 6dd3358..de29501 100644 > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION > reg = 0 > .rept 32 > li r6,reg*16+VCPU_VSRS > - stxvd2x reg,r6,r3 > + STXVD2X(reg,r6,r3) > reg = reg + 1 > .endr > FTR_SECTION_ELSE > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION > reg = 0 > .rept 32 > li r7,reg*16+VCPU_VSRS > - lxvd2x reg,r7,r4 > + LXVD2X(reg,r7,r4) > reg = reg + 1 > .endr > FTR_SECTION_ELSE