From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space() Date: Wed, 10 Aug 2011 19:35:34 +0300 Message-ID: <4E42B356.9090809@redhat.com> References: <1312823229-12822-1-git-send-email-avi@redhat.com> <1312823229-12822-22-git-send-email-avi@redhat.com> <4E42B0A5.1010005@twiddle.net> <4E42B123.8070605@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Richard Henderson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60919 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284Ab1HJQfj (ORCPT ); Wed, 10 Aug 2011 12:35:39 -0400 In-Reply-To: <4E42B123.8070605@twiddle.net> Sender: kvm-owner@vger.kernel.org List-ID: On 08/10/2011 07:26 PM, Richard Henderson wrote: > On 08/10/2011 09:24 AM, Richard Henderson wrote: > > Of course, as far as I can see, this variable is only used by > > the VGA devices. Surely we can arrange to pass down some address > > space during setup of the VGA? > > ... Which seems to be what you've done in patch 23. > > So what's the point of this patch? > > Okay, so I'm learning a lot and also applying that learning... a good thing except that I've forgotten all about it. Had a similar case with omap_gpmc. Again, there's so much work here that the quality is bound to be less than perfect. The plan is to have a pretty good end result though (fully hierarchical - no globals). -- error compiling committee.c: too many arguments to function