From: Jens Axboe <jaxboe@fusionio.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>, Christoph Hellwig <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 2/2] blktrace: add FLUSH/FUA support
Date: Thu, 11 Aug 2011 10:36:42 +0200 [thread overview]
Message-ID: <4E43949A.7000306@fusionio.com> (raw)
In-Reply-To: <x497h6ls781.fsf@segfault.boston.devel.redhat.com>
On 2011-08-10 15:53, Jeff Moyer wrote:
> Namhyung Kim <namhyung@gmail.com> writes:
>
>> Add FLUSH/FUA support to blktrace. As FLUSH precedes WRITE and/or
>> FUA follows WRITE, use the same 'F' flag for both cases and
>> distinguish them by their (relative) position. The end results
>> look like (other flags might be shown also):
>>
>> - WRITE: W
>> - WRITE_FLUSH: FW
>> - WRITE_FUA: WF
>> - WRITE_FLUSH_FUA: FWF
>
> I was hoping we'd go with Jens' suggestion of relacing W with F for flush,
> and have FUA appear after that. However, I can live with this, so if
> others like it, it's fine by me.
The single 'F' would have been cleaner, but at least this is consistent.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2011-08-11 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 6:32 [PATCH 1/2] Move some REQ flags to the common bio/request area Namhyung Kim
2011-08-10 6:32 ` [PATCH v2 2/2] blktrace: add FLUSH/FUA support Namhyung Kim
2011-08-10 13:53 ` Jeff Moyer
2011-08-11 8:36 ` Jens Axboe [this message]
2011-08-10 13:52 ` [PATCH 1/2] Move some REQ flags to the common bio/request area Jeff Moyer
2011-08-11 8:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E43949A.7000306@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fweisbec@gmail.com \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.