From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7BH9ZIE258217 for ; Thu, 11 Aug 2011 12:09:35 -0500 Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0D90ED3652 for ; Thu, 11 Aug 2011 10:09:34 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id bfLNEevSaW62Mgyq for ; Thu, 11 Aug 2011 10:09:34 -0700 (PDT) Message-ID: <4E4408D9.4050706@redhat.com> Date: Thu, 11 Aug 2011 12:52:41 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback References: <1312973240-32576-1-git-send-email-mgorman@suse.de> <1312973240-32576-3-git-send-email-mgorman@suse.de> In-Reply-To: <1312973240-32576-3-git-send-email-mgorman@suse.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mel Gorman Cc: Jan Kara , LKML , XFS , Christoph Hellwig , Linux-MM , Minchan Kim , Wu Fengguang , Johannes Weiner On 08/10/2011 06:47 AM, Mel Gorman wrote: > Lumpy reclaim worked with two passes - the first which queued pages for > IO and the second which waited on writeback. As direct reclaim can no > longer write pages there is some dead code. This patch removes it but > direct reclaim will continue to wait on pages under writeback while in > synchronous reclaim mode. > > Signed-off-by: Mel Gorman Reviewed-by: Rik van Riel _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479Ab1HKRJv (ORCPT ); Thu, 11 Aug 2011 13:09:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23448 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423Ab1HKRJm (ORCPT ); Thu, 11 Aug 2011 13:09:42 -0400 Message-ID: <4E4408D9.4050706@redhat.com> Date: Thu, 11 Aug 2011 12:52:41 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1 MIME-Version: 1.0 To: Mel Gorman CC: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Minchan Kim Subject: Re: [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback References: <1312973240-32576-1-git-send-email-mgorman@suse.de> <1312973240-32576-3-git-send-email-mgorman@suse.de> In-Reply-To: <1312973240-32576-3-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2011 06:47 AM, Mel Gorman wrote: > Lumpy reclaim worked with two passes - the first which queued pages for > IO and the second which waited on writeback. As direct reclaim can no > longer write pages there is some dead code. This patch removes it but > direct reclaim will continue to wait on pages under writeback while in > synchronous reclaim mode. > > Signed-off-by: Mel Gorman Reviewed-by: Rik van Riel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 842E26B00EE for ; Thu, 11 Aug 2011 13:09:34 -0400 (EDT) Message-ID: <4E4408D9.4050706@redhat.com> Date: Thu, 11 Aug 2011 12:52:41 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback References: <1312973240-32576-1-git-send-email-mgorman@suse.de> <1312973240-32576-3-git-send-email-mgorman@suse.de> In-Reply-To: <1312973240-32576-3-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Minchan Kim On 08/10/2011 06:47 AM, Mel Gorman wrote: > Lumpy reclaim worked with two passes - the first which queued pages for > IO and the second which waited on writeback. As direct reclaim can no > longer write pages there is some dead code. This patch removes it but > direct reclaim will continue to wait on pages under writeback while in > synchronous reclaim mode. > > Signed-off-by: Mel Gorman Reviewed-by: Rik van Riel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org