From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36993)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QrZmd-0004mH-CT
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 14:15:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QrZmY-0002Ot-B9
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 14:15:07 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:47069)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QrZmY-0002OJ-3L
	for qemu-devel@nongnu.org; Thu, 11 Aug 2011 14:15:02 -0400
Received: by wyf22 with SMTP id 22so1798646wyf.4
	for <qemu-devel@nongnu.org>; Thu, 11 Aug 2011 11:15:00 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E441C1F.5090902@twiddle.net>
Date: Thu, 11 Aug 2011 11:14:55 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1313059839-2445-1-git-send-email-agraf@suse.de>
	<alpine.LNX.2.00.1108111516440.7304@linmac>
	<F4757B4A-4D57-4796-BC3C-AED2C376A59E@suse.de>
	<4E43CAE9.3080209@redhat.com>
	<1BD39142-C48A-426B-8901-0D2703033296@suse.de>
	<4E43D1FA.6080600@redhat.com>
	<CAAu8pHsHWDeskgELDcm+5zt1_AbkApFhfkFvMBgf0nKBbX0Opw@mail.gmail.com>
In-Reply-To: <CAAu8pHsHWDeskgELDcm+5zt1_AbkApFhfkFvMBgf0nKBbX0Opw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional
 tcg ops
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel Developers <qemu-devel@nongnu.org>, Kirill Batuzov <batuzovk@ispras.ru>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>, Avi Kivity <avi@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

On 08/11/2011 09:38 AM, Blue Swirl wrote:
> On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity <avi@redhat.com> wrote:
>> On 08/11/2011 03:36 PM, Alexander Graf wrote:
>>>
>>>>
>>>>  Or to have automatic generation of the optionals based on the
>>>> primitives, if the optionals are not present.
>>>
>>> That's what's happening in the background already, no? The line is towards
>>> tcg users though, not it tcg internal code.
>>>
>>
>> Yes, and it doesn't make sense to optimize through synthetic instructions.
> 
> I'd just create all INDEX_op_* enums and adjust TCG targets etc. to
> call tcg_abort() in the default case.
> 

Seconded.  We can still expand the optional enums exactly as we do now,
but make sure that the enum is always present.  That'll clean up a *lot*
of ifdefs throughout tcg/*.


r~