All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: linville@tuxdriver.com
Cc: Felix Fietkau <nbd@openwrt.org>,
	linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
	jouni@qca.qualcomm.com
Subject: Re: [PATCH] cfg80211: fix a crash in nl80211_send_station
Date: Thu, 11 Aug 2011 16:38:10 -0500	[thread overview]
Message-ID: <4E444BC2.40204@lwfinger.net> (raw)
In-Reply-To: <1313024433-35053-1-git-send-email-nbd@openwrt.org>

On 08/10/2011 08:00 PM, Felix Fietkau wrote:
> mac80211 leaves sinfo->assoc_req_ies uninitialized, causing a random
> pointer memory access in nl80211_send_station.
> Instead of checking if the pointer is null, use sinfo->filled, like
> the rest of the fields.
>
> Signed-off-by: Felix Fietkau<nbd@openwrt.org>

John,

I hope this patch will be added to wireless-testing soon. It is particularly 
insidious as it leads to kernel panics or spontaneous reboots. Note: the problem 
occurs even when the NIC is not being used as an AP.

Thanks,

Larry

      parent reply	other threads:[~2011-08-11 21:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11  1:00 [PATCH] cfg80211: fix a crash in nl80211_send_station Felix Fietkau
2011-08-11  8:15 ` Jouni Malinen
2011-08-11 21:38 ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E444BC2.40204@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.