From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: Allocating buffers for USB transfers (again) Date: Fri, 12 Aug 2011 01:40:35 +0200 Message-ID: <4E446873.9020508@gmail.com> References: <20110811180507.GC5884@xanatos> <3166003.Y8gKYdUrh9@edgy> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) by alsa0.perex.cz (Postfix) with ESMTP id A4ECA103961 for ; Fri, 12 Aug 2011 01:40:39 +0200 (CEST) Received: by wyh22 with SMTP id 22so1902490wyh.38 for ; Thu, 11 Aug 2011 16:40:39 -0700 (PDT) In-Reply-To: <3166003.Y8gKYdUrh9@edgy> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: =?UTF-8?B?TWF0xJtqIExhaXRs?= Cc: William Light , alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, Sarah Sharp , Greg KH , Oliver Neukum , Clemens Ladisch , linux-kernel@vger.kernel.org, Florian Mickler , Alan Stern , Takashi Iwai , pedrib@gmail.com, Robert Hancock List-Id: alsa-devel@alsa-project.org T24gMDgvMTIvMjAxMSAwMToyOSBBTSwgTWF0xJtqIExhaXRsIHdyb3RlOgo+IE9uIDExLuKArzgu 4oCvMjAxMSBEYW5pZWwgTWFjayB3cm90ZToKPj4gT24gVGh1LCBBdWcgMTEsIDIwMTEgYXQgODow NSBQTSwgU2FyYWggU2hhcnAKPj4+IEJlY2F1c2UgYWNjb3JkaW5nIHRvIE1hdGVqLCBoZSBhcHBs aWVkIHRoYXQgcGF0Y2gsIHBsdXMgbXkgcGF0Y2ggdG8KPj4+IHJlamVjdCB6ZXJvLWxlbmd0aCBi dWZmZXJzWzFdLCBhbmQgaGUgc2F3IGRlYnVnZ2luZyB0aGF0IGluZGljYXRlZCBoZQo+Pj4gKmRp ZCogc2VlIHplcm8tbGVuZ3RoIGJ1ZmZlcnMuICBJcyB0aGVyZSBhbnkgY2hhbmNlIHlvdXIgZHJp dmVyIG1pZ2h0Cj4+PiBzdWJtaXQgYSB6ZXJvLWxlbmd0aCBidWZmZXIgaW4gdGhlIG1pZGRsZSBv ZiB0aGUgaXNvY2hyb25vdXMgVVJCCj4+PiB0cmFuc2ZlciBhcnJheT8KPj4KPj4gSG1tLCBqdWRn aW5nIGZyb20gdGhlIGNvZGUsIHRoaXMgY2FuIG9ubHkgZXZlciBoYXBwZW4gaWYgd2UgcmVjZWl2 ZSBhbgo+PiBpbmJvdW5kIGlzbyBmcmFtZSB3aGljaCBoYXMgYSB2YWxpZCBzdGF0dXMgYW5kIGFu IGFjdHVhbF9sZW5ndGggb2YKPj4gemVyby4gQWxzbywgaXQgd2FzIG5vdCBuZWNjZXNzYXJ5IHRv IGNhdGNoIHRoaXMgY2FzZSBmb3IgRUhDSS4KPj4KPj4gTWFldGosIGRvZXMgdGhpcyBwYXRjaCBt YWtlIGFueSBkaWZmZXJlbmNlPwo+Cj4gVGhpcyBwYXRjaCBhY3R1YWxseSBtYWtlcyB0aGUgc291 bmQgcGxheWJhY2sgX3dvcnNlXy4gTm93IEkgZ2V0IHN0cmFuZ2UKPiBzcXVhd2tzIHdoZXJlIHBy ZXZpb3VzbHkgYXQgbGVhc3QgZmlyc3Qgc2Vjb25kcyBvZiBhIHNvbmcgc291bmRlZCBub3JtYWxs eS4KPgo+IEhvd2V2ZXIsIEkgbm8gbG9uZ2VyIGdldCAiemVybyBsZW5ndGggYnVmZmVyIHN1Ym1p dHRlZCIgb3IgdGhhdCAiLi4uIFdlaXJkLiIKPiBkZWJ1ZyBtZXNzYWdlcywgb25seSBzZXZlcmFs IG1lZ2FieXRlcyBvZjogKHNob3VsZCBJIHBvc3QgdGhlc2Ugc29tZXdoZXJlPykKPgo+IHhoY2lf aGNkIDAwMDA6MDU6MDAuMDogR2l2ZWJhY2sgVVJCIGZmZmY4ODAxMTRjZWMwMDAsIGxlbiA9IDg4 MCwgZXhwZWN0ZWQgPQo+IDEwMDAsIHN0YXR1cyA9IC0xMTUKPiB4aGNpX2hjZCAwMDAwOjA1OjAw LjA6IEdpdmViYWNrIFVSQiBmZmZmODgwMTE0NzQwMDAwLCBsZW4gPSAzNTIsIGV4cGVjdGVkID0K PiAxMDAwLCBzdGF0dXMgPSAtMTE1Cj4geGhjaV9oY2QgMDAwMDowNTowMC4wOiB1bmRlcnJ1biBl dmVudCBvbiBlbmRwb2ludAoKTWlnaHQgYmUgdGhlIGhhcmR3YXJlIGRvZXNuJ3QgbGlrZSB0aGlz LiBBcyBJIHNhaWQsIHRoZSBwYXRjaCBpcyBibGluZGx5IAp3cml0dGVuIGFuZCBJIGNvdWxkbid0 IHRlc3QgaXQuIERpZCB5b3UgdGVzdCB0aGlzIG9uIGEgRUhDSSBwb3J0IGFzIHdlbGw/CgpEYW5p ZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2Et ZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFp bG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754448Ab1HKXkp (ORCPT ); Thu, 11 Aug 2011 19:40:45 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:39801 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754417Ab1HKXkk (ORCPT ); Thu, 11 Aug 2011 19:40:40 -0400 Message-ID: <4E446873.9020508@gmail.com> Date: Fri, 12 Aug 2011 01:40:35 +0200 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: =?UTF-8?B?TWF0xJtqIExhaXRs?= CC: Sarah Sharp , Alan Stern , Florian Mickler , Oliver Neukum , linux-usb@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Clemens Ladisch , pedrib@gmail.com, William Light , Greg KH , linux-kernel@vger.kernel.org, Robert Hancock Subject: Re: Allocating buffers for USB transfers (again) References: <20110811180507.GC5884@xanatos> <3166003.Y8gKYdUrh9@edgy> In-Reply-To: <3166003.Y8gKYdUrh9@edgy> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2011 01:29 AM, Matěj Laitl wrote: > On 11. 8. 2011 Daniel Mack wrote: >> On Thu, Aug 11, 2011 at 8:05 PM, Sarah Sharp >>> Because according to Matej, he applied that patch, plus my patch to >>> reject zero-length buffers[1], and he saw debugging that indicated he >>> *did* see zero-length buffers. Is there any chance your driver might >>> submit a zero-length buffer in the middle of the isochronous URB >>> transfer array? >> >> Hmm, judging from the code, this can only ever happen if we receive an >> inbound iso frame which has a valid status and an actual_length of >> zero. Also, it was not neccessary to catch this case for EHCI. >> >> Maetj, does this patch make any difference? > > This patch actually makes the sound playback _worse_. Now I get strange > squawks where previously at least first seconds of a song sounded normally. > > However, I no longer get "zero length buffer submitted" or that "... Weird." > debug messages, only several megabytes of: (should I post these somewhere?) > > xhci_hcd 0000:05:00.0: Giveback URB ffff880114cec000, len = 880, expected = > 1000, status = -115 > xhci_hcd 0000:05:00.0: Giveback URB ffff880114740000, len = 352, expected = > 1000, status = -115 > xhci_hcd 0000:05:00.0: underrun event on endpoint Might be the hardware doesn't like this. As I said, the patch is blindly written and I couldn't test it. Did you test this on a EHCI port as well? Daniel