All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
	XFS <xfs@oss.sgi.com>, Christoph Hellwig <hch@infradead.org>,
	Linux-MM <linux-mm@kvack.org>,
	Minchan Kim <minchan.kim@gmail.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Johannes Weiner <jweiner@redhat.com>
Subject: Re: [PATCH 6/7] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback
Date: Thu, 11 Aug 2011 22:47:33 -0400	[thread overview]
Message-ID: <4E449445.9000205@redhat.com> (raw)
In-Reply-To: <1312973240-32576-7-git-send-email-mgorman@suse.de>

On 08/10/2011 06:47 AM, Mel Gorman wrote:
> Workloads that are allocating frequently and writing files place a
> large number of dirty pages on the LRU. With use-once logic, it is
> possible for them to reach the end of the LRU quickly requiring the
> reclaimer to scan more to find clean pages. Ordinarily, processes that
> are dirtying memory will get throttled by dirty balancing but this
> is a global heuristic and does not take into account that LRUs are
> maintained on a per-zone basis. This can lead to a situation whereby
> reclaim is scanning heavily, skipping over a large number of pages
> under writeback and recycling them around the LRU consuming CPU.
>
> This patch checks how many of the number of pages isolated from the
> LRU were dirty and under writeback. If a percentage of them under
> writeback, the process will be throttled if a backing device or the
> zone is congested. Note that this applies whether it is anonymous or
> file-backed pages that are under writeback meaning that swapping is
> potentially throttled. This is intentional due to the fact if the
> swap device is congested, scanning more pages and dispatching more
> IO is not going to help matters.
>
> The percentage that must be in writeback depends on the priority. At
> default priority, all of them must be dirty. At DEF_PRIORITY-1, 50%
> of them must be, DEF_PRIORITY-2, 25% etc. i.e. as pressure increases
> the greater the likelihood the process will get throttled to allow
> the flusher threads to make some progress.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
> Acked-by: Johannes Weiner<jweiner@redhat.com>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>, XFS <xfs@oss.sgi.com>,
	Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@infradead.org>,
	Johannes Weiner <jweiner@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
	Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [PATCH 6/7] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback
Date: Thu, 11 Aug 2011 22:47:33 -0400	[thread overview]
Message-ID: <4E449445.9000205@redhat.com> (raw)
In-Reply-To: <1312973240-32576-7-git-send-email-mgorman@suse.de>

On 08/10/2011 06:47 AM, Mel Gorman wrote:
> Workloads that are allocating frequently and writing files place a
> large number of dirty pages on the LRU. With use-once logic, it is
> possible for them to reach the end of the LRU quickly requiring the
> reclaimer to scan more to find clean pages. Ordinarily, processes that
> are dirtying memory will get throttled by dirty balancing but this
> is a global heuristic and does not take into account that LRUs are
> maintained on a per-zone basis. This can lead to a situation whereby
> reclaim is scanning heavily, skipping over a large number of pages
> under writeback and recycling them around the LRU consuming CPU.
>
> This patch checks how many of the number of pages isolated from the
> LRU were dirty and under writeback. If a percentage of them under
> writeback, the process will be throttled if a backing device or the
> zone is congested. Note that this applies whether it is anonymous or
> file-backed pages that are under writeback meaning that swapping is
> potentially throttled. This is intentional due to the fact if the
> swap device is congested, scanning more pages and dispatching more
> IO is not going to help matters.
>
> The percentage that must be in writeback depends on the priority. At
> default priority, all of them must be dirty. At DEF_PRIORITY-1, 50%
> of them must be, DEF_PRIORITY-2, 25% etc. i.e. as pressure increases
> the greater the likelihood the process will get throttled to allow
> the flusher threads to make some progress.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
> Acked-by: Johannes Weiner<jweiner@redhat.com>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>, XFS <xfs@oss.sgi.com>,
	Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@infradead.org>,
	Johannes Weiner <jweiner@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
	Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [PATCH 6/7] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback
Date: Thu, 11 Aug 2011 22:47:33 -0400	[thread overview]
Message-ID: <4E449445.9000205@redhat.com> (raw)
In-Reply-To: <1312973240-32576-7-git-send-email-mgorman@suse.de>

On 08/10/2011 06:47 AM, Mel Gorman wrote:
> Workloads that are allocating frequently and writing files place a
> large number of dirty pages on the LRU. With use-once logic, it is
> possible for them to reach the end of the LRU quickly requiring the
> reclaimer to scan more to find clean pages. Ordinarily, processes that
> are dirtying memory will get throttled by dirty balancing but this
> is a global heuristic and does not take into account that LRUs are
> maintained on a per-zone basis. This can lead to a situation whereby
> reclaim is scanning heavily, skipping over a large number of pages
> under writeback and recycling them around the LRU consuming CPU.
>
> This patch checks how many of the number of pages isolated from the
> LRU were dirty and under writeback. If a percentage of them under
> writeback, the process will be throttled if a backing device or the
> zone is congested. Note that this applies whether it is anonymous or
> file-backed pages that are under writeback meaning that swapping is
> potentially throttled. This is intentional due to the fact if the
> swap device is congested, scanning more pages and dispatching more
> IO is not going to help matters.
>
> The percentage that must be in writeback depends on the priority. At
> default priority, all of them must be dirty. At DEF_PRIORITY-1, 50%
> of them must be, DEF_PRIORITY-2, 25% etc. i.e. as pressure increases
> the greater the likelihood the process will get throttled to allow
> the flusher threads to make some progress.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
> Acked-by: Johannes Weiner<jweiner@redhat.com>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-08-12  2:47 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 10:47 [PATCH 0/7] Reduce filesystem writeback from page reclaim v3 Mel Gorman
2011-08-10 10:47 ` Mel Gorman
2011-08-10 10:47 ` Mel Gorman
2011-08-10 10:47 ` [PATCH 1/7] mm: vmscan: Do not writeback filesystem pages in direct reclaim Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 12:40   ` Johannes Weiner
2011-08-10 12:40     ` Johannes Weiner
2011-08-10 12:40     ` Johannes Weiner
2011-08-11  9:03   ` KAMEZAWA Hiroyuki
2011-08-11  9:03     ` KAMEZAWA Hiroyuki
2011-08-11  9:03     ` KAMEZAWA Hiroyuki
2011-08-11 15:57   ` Rik van Riel
2011-08-11 15:57     ` Rik van Riel
2011-08-11 15:57     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 12:41   ` Johannes Weiner
2011-08-10 12:41     ` Johannes Weiner
2011-08-10 12:41     ` Johannes Weiner
2011-08-10 23:19   ` Minchan Kim
2011-08-10 23:19     ` Minchan Kim
2011-08-10 23:19     ` Minchan Kim
2011-08-11  9:05   ` KAMEZAWA Hiroyuki
2011-08-11  9:05     ` KAMEZAWA Hiroyuki
2011-08-11  9:05     ` KAMEZAWA Hiroyuki
2011-08-11 16:52   ` Rik van Riel
2011-08-11 16:52     ` Rik van Riel
2011-08-11 16:52     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 3/7] xfs: Warn if direct reclaim tries to writeback pages Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-11 16:53   ` Rik van Riel
2011-08-11 16:53     ` Rik van Riel
2011-08-11 16:53     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 4/7] ext4: " Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-11 17:07   ` Rik van Riel
2011-08-11 17:07     ` Rik van Riel
2011-08-11 17:07     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 5/7] mm: vmscan: Do not writeback filesystem pages in kswapd except in high priority Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 12:44   ` Johannes Weiner
2011-08-10 12:44     ` Johannes Weiner
2011-08-10 12:44     ` Johannes Weiner
2011-08-11  9:10   ` KAMEZAWA Hiroyuki
2011-08-11  9:10     ` KAMEZAWA Hiroyuki
2011-08-11  9:10     ` KAMEZAWA Hiroyuki
2011-08-11 20:25     ` Mel Gorman
2011-08-11 20:25       ` Mel Gorman
2011-08-11 20:25       ` Mel Gorman
2011-08-17  1:06       ` KAMEZAWA Hiroyuki
2011-08-17  1:06         ` KAMEZAWA Hiroyuki
2011-08-17  1:06         ` KAMEZAWA Hiroyuki
2011-08-11 18:18   ` Rik van Riel
2011-08-11 18:18     ` Rik van Riel
2011-08-11 18:18     ` Rik van Riel
2011-08-11 20:38     ` Mel Gorman
2011-08-11 20:38       ` Mel Gorman
2011-08-11 20:38       ` Mel Gorman
2011-08-10 10:47 ` [PATCH 6/7] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-11  9:18   ` KAMEZAWA Hiroyuki
2011-08-11  9:18     ` KAMEZAWA Hiroyuki
2011-08-11  9:18     ` KAMEZAWA Hiroyuki
2011-08-12  2:47   ` Rik van Riel [this message]
2011-08-12  2:47     ` Rik van Riel
2011-08-12  2:47     ` Rik van Riel
2011-08-16 14:06   ` Wu Fengguang
2011-08-16 14:06     ` Wu Fengguang
2011-08-16 14:06     ` Wu Fengguang
2011-08-16 15:02     ` Mel Gorman
2011-08-16 15:02       ` Mel Gorman
2011-08-16 15:02       ` Mel Gorman
2011-08-18 14:02       ` Wu Fengguang
2011-08-18 14:02         ` Wu Fengguang
2011-08-18 14:02         ` Wu Fengguang
2011-08-18 23:54   ` Andrew Morton
2011-08-18 23:54     ` Andrew Morton
2011-08-18 23:54     ` Andrew Morton
2011-08-30 13:49     ` Mel Gorman
2011-08-30 13:49       ` Mel Gorman
2011-08-30 13:49       ` Mel Gorman
2011-08-31  9:53     ` Mel Gorman
2011-08-31  9:53       ` Mel Gorman
2011-08-31  9:53       ` Mel Gorman
2011-08-10 10:47 ` [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 23:22   ` Minchan Kim
2011-08-10 23:22     ` Minchan Kim
2011-08-10 23:22     ` Minchan Kim
2011-08-11  9:19   ` KAMEZAWA Hiroyuki
2011-08-11  9:19     ` KAMEZAWA Hiroyuki
2011-08-11  9:19     ` KAMEZAWA Hiroyuki
2011-08-12 15:27   ` Rik van Riel
2011-08-12 15:27     ` Rik van Riel
2011-08-12 15:27     ` Rik van Riel
2011-08-10 11:00 ` [PATCH 0/7] Reduce filesystem writeback from page reclaim v3 Christoph Hellwig
2011-08-10 11:00   ` Christoph Hellwig
2011-08-10 11:00   ` Christoph Hellwig
2011-08-10 11:15   ` Mel Gorman
2011-08-10 11:15     ` Mel Gorman
2011-08-10 11:15     ` Mel Gorman
2011-08-11 23:45     ` Christoph Hellwig
2011-08-11 23:45       ` Christoph Hellwig
2011-08-11 23:45       ` Christoph Hellwig
2011-08-18 23:54 ` Andrew Morton
2011-08-18 23:54   ` Andrew Morton
2011-08-18 23:54   ` Andrew Morton
2011-08-20 19:33   ` Mel Gorman
2011-08-20 19:33     ` Mel Gorman
2011-08-20 19:33     ` Mel Gorman
2011-08-30 13:19   ` Mel Gorman
2011-08-30 13:19     ` Mel Gorman
2011-08-30 13:19     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E449445.9000205@redhat.com \
    --to=riel@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jweiner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan.kim@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.