From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Amadeusz Żołnowski" <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] crypt: dropped plymouth --has-active-vt check on passwd prompt
Date: Fri, 12 Aug 2011 08:21:01 +0200 [thread overview]
Message-ID: <4E44C64D.2020501@redhat.com> (raw)
In-Reply-To: <1309470560-16173-1-git-send-email-aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
On 30.06.2011 23:49, Amadeusz Żołnowski wrote:
> As Ray Strode explains, plymouth --has-active-vt may fail if the user
> passes console=ttyS0 or something other not corresponding to
> console=tty0, because plymouth is outputing to the serial console and
> not a VT in this case.
> ---
> modules.d/90crypt/crypt-lib.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/modules.d/90crypt/crypt-lib.sh b/modules.d/90crypt/crypt-lib.sh
> index 122d88e..3ef8482 100644
> --- a/modules.d/90crypt/crypt-lib.sh
> +++ b/modules.d/90crypt/crypt-lib.sh
> @@ -47,7 +47,7 @@ ask_for_password() {
>
> { flock -s 9;
> # Prompt for password with plymouth, if installed and running.
> - if [ -x /bin/plymouth ] && /bin/plymouth --has-active-vt; then
> + if [ -x /bin/plymouth ]; then
> /bin/plymouth ask-for-password \
> --prompt "$ply_prompt" --number-of-tries=$ply_tries \
> --command="$ply_cmd"
pushed
prev parent reply other threads:[~2011-08-12 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 21:49 [PATCH] crypt: dropped plymouth --has-active-vt check on passwd prompt Amadeusz Żołnowski
[not found] ` <1309470560-16173-1-git-send-email-aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
2011-08-12 6:21 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E44C64D.2020501@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.