Re: [PATCHv3 2/5] GPRS context plan support

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Hi Oleg,

On 08/05/2011 07:25 AM, Oleg Zhurakivskyy wrote:
> ---
>  include/gprs-context.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 

Logically this patch is out of order since you make use of these defines
in Patch 1.

> diff --git a/include/gprs-context.h b/include/gprs-context.h
> index f82fcaa..8dfc106 100644
> --- a/include/gprs-context.h
> +++ b/include/gprs-context.h
> @@ -48,6 +48,11 @@ enum ofono_gprs_context_type {
>  	OFONO_GPRS_CONTEXT_TYPE_IMS,
>  };
>  
> +enum ofono_gprs_context_plan {
> +	OFONO_GPRS_CONTEXT_PLAN_PREPAID,
> +	OFONO_GPRS_CONTEXT_PLAN_POSTPAID,
> +};
> +

What exactly is the usecase here?  oFono doesn't really care whether a
plan is prepaid or postpaid, that is information purely for the UI.

>  struct ofono_gprs_primary_context {
>  	unsigned int cid;
>  	int direction;

Regards,
-Denis