From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Qrs3s-0000fK-PV
	for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:46:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Qrs3r-0000Rt-Kl
	for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:46:08 -0400
Received: from e32.co.us.ibm.com ([32.97.110.150]:52501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Qrs3r-0000Rf-EV
	for qemu-devel@nongnu.org; Fri, 12 Aug 2011 09:46:07 -0400
Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com
	[9.17.195.107])
	by e32.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7CCZxYW031501
	for <qemu-devel@nongnu.org>; Fri, 12 Aug 2011 06:35:59 -0600
Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85])
	by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP
	id p7CDjotL101970
	for <qemu-devel@nongnu.org>; Fri, 12 Aug 2011 07:45:52 -0600
Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1])
	by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p7CDjnEw021486
	for <qemu-devel@nongnu.org>; Fri, 12 Aug 2011 07:45:50 -0600
Message-ID: <4E452E8B.1090604@us.ibm.com>
Date: Fri, 12 Aug 2011 08:45:47 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1312999851-28390-1-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1312999851-28390-1-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH STABLE] qapi: fix build issue due to
 missing newline in generated header
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

On 08/10/2011 01:10 PM, Michael Roth wrote:
> Fixes a build issue on RHEL5, and potentially other distros, where gcc
> will generate an error due to us not writing a trailing "\n" when
> generating *qmp-commands.h
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>

Applied to master.  Thanks.

Regards,

Anthony Liguori

> ---
>   scripts/qapi-commands.py |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
> index 9ad4c54..bf61740 100644
> --- a/scripts/qapi-commands.py
> +++ b/scripts/qapi-commands.py
> @@ -375,7 +375,7 @@ if dispatch_type == "sync":
>           ret = gen_marshal_input(cmd['command'], arglist, ret_type) + "\n"
>           fdef.write(ret)
>
> -    fdecl.write("\n#endif");
> +    fdecl.write("\n#endif\n");
>       ret = gen_registry(commands)
>       fdef.write(ret)
>