Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

[Anthony Liguori <anthony@codemonkey.ws>]

On 08/08/2011 11:58 AM, Avi Kivity wrote:
> ROM/device regions act as mapped RAM for reads, can I/O memory for
> writes.  This allow emulation of flash devices.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   memory.c |   46 ++++++++++++++++++++++++++++++++++++++++++++--
>   memory.h |   34 ++++++++++++++++++++++++++++++++++
>   2 files changed, 78 insertions(+), 2 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 5e3d966..beff98c 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -125,6 +125,7 @@ struct FlatRange {
>       target_phys_addr_t offset_in_region;
>       AddrRange addr;
>       uint8_t dirty_log_mask;
> +    bool readable;

In a follow up, it might be good to add a comment explaining that this 
whole readable thing is not just an optimization, but a hard requirement 
for KVM in order to be able to execute code from ROM.

Regards,

Anthony Liguori