From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59404)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.niederl@iaik.tugraz.at>) id 1Qrt9N-00046h-HM
	for qemu-devel@nongnu.org; Fri, 12 Aug 2011 10:55:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.niederl@iaik.tugraz.at>) id 1Qrt9M-0005yQ-Gp
	for qemu-devel@nongnu.org; Fri, 12 Aug 2011 10:55:53 -0400
Received: from smtp.tu-graz.ac.at ([129.27.2.202]:47119
	helo=mailrelay.tugraz.at) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.niederl@iaik.tugraz.at>) id 1Qrt9L-0005yH-Rr
	for qemu-devel@nongnu.org; Fri, 12 Aug 2011 10:55:52 -0400
Message-ID: <4E453ECA.30707@iaik.tugraz.at>
Date: Fri, 12 Aug 2011 16:55:06 +0200
From: Andreas Niederl <andreas.niederl@iaik.tugraz.at>
MIME-Version: 1.0
References: <20110810192919.425976163@linux.vnet.ibm.com>
	<20110810193018.619841098@linux.vnet.ibm.com>
In-Reply-To: <20110810193018.619841098@linux.vnet.ibm.com>
Content-Type: multipart/mixed; boundary="------------080605070206030506030909"
Subject: Re: [Qemu-devel] [PATCH V7 13/13] Add a TPM backend null driver
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------080605070206030506030909
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mailrelay1.tugraz.at id p7CEtdWs012403

Hi,
the null driver backend generates a warning for me on gcc-4.4.5:

cc1: warnings being treated as errors
/home/aniederl/work/actvsm/qemu/hw/tpm_null.c: In function =91tpm_null_ma=
in_loop=92:
/home/aniederl/work/actvsm/qemu/hw/tpm_null.c:107: error: =91in=92 may be=
 used uninitialized in this function
make[1]: *** [tpm_null.o] Error 1

The attached patch fixes this.


Regards,
Andreas

--------------080605070206030506030909
Content-Type: text/plain;
 name="qemu_tpm_be_null_init.diff"
Content-Disposition: attachment;
 filename="qemu_tpm_be_null_init.diff"
Content-Transfer-Encoding: 7bit

commit a4f91be3b14c412d47a711505edf9be8816dde26
Author: Andreas Niederl <andreas.niederl@iaik.tugraz.at>
Date:   Fri Aug 12 14:39:48 2011 +0200

    Fix uninitialized variable warning in tpm_null driver

diff --git a/hw/tpm_null.c b/hw/tpm_null.c
index d8d4fda..ce0b8f0 100644
--- a/hw/tpm_null.c
+++ b/hw/tpm_null.c
@@ -97,6 +97,7 @@ static void *tpm_null_main_loop(void *d)
 
             locty = thr_parms->tpm_state->command_locty;
 
+            in     = thr_parms->tpm_state->loc[locty].w_buffer.buffer;
             in_len = thr_parms->tpm_state->loc[locty].w_offset;
 
             out = thr_parms->tpm_state->loc[locty].r_buffer.buffer;

--------------080605070206030506030909--