Re: [CONSOLIDATED PULL 17/25] meta-rt: rt-tests v0.73 instead of AUTOREV

From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [CONSOLIDATED PULL 17/25] meta-rt: rt-tests v0.73 instead of AUTOREV
Date: Fri, 12 Aug 2011 09:30:26 -0700	[thread overview]
Message-ID: <4E455522.6040303@linux.intel.com> (raw)
In-Reply-To: <1313165371.14274.509.camel@rex>

On 08/12/2011 09:09 AM, Richard Purdie wrote:
> On Fri, 2011-08-12 at 00:50 -0700, Saul Wold wrote:
>> From: Darren Hart <dvhart@linux.intel.com>
>>
>> AUTOREV is handy is a development aid, but it really shouldn't be used as a
>> default as it breaks the consistency and repeatability of a build. It also
>> causes additional fetches which may not be desired or expected.
>>
>> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
>> ---
>>  .../{rt-tests_git.bb => rt-tests_0.73.bb}          |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>  rename meta-rt/recipes-tests/{rt-tests_git.bb => rt-tests_0.73.bb} (97%)
>>
>> diff --git a/meta-rt/recipes-tests/rt-tests_git.bb b/meta-rt/recipes-tests/rt-tests_0.73.bb
>> similarity index 97%
>> rename from meta-rt/recipes-tests/rt-tests_git.bb
>> rename to meta-rt/recipes-tests/rt-tests_0.73.bb
>> index 35af022..6334bcd 100644
>> --- a/meta-rt/recipes-tests/rt-tests_git.bb
>> +++ b/meta-rt/recipes-tests/rt-tests_0.73.bb
>> @@ -6,7 +6,7 @@ LICENSE = "GPLv2 & GPLv2+"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
>>                      file://src/cyclictest/cyclictest.c;beginline=7;endline=9;md5=ce162fe491d19d2ec67dff6dbc938d50 \
>>                      file://src/pi_tests/pi_stress.c;beginline=6;endline=19;md5=bd426a634a43ec612e9fbf125dfcc949"
>> -SRCREV = ${AUTOREV}
>> +SRCREV = v0.73
>>  PV = "git${SRCPV}"
>>  PR = "r0"
> 
> Sorry, but this is nearly as bad as the system has to hit the network to
> resolve "v0.73" into a revision. Please can you do something like:

Duh. Apologies. I'll spin up a fix immediately.

--
Darren

> 
> # This revision is v0.73
> SRCREV = "xxx"
> 
> which I appreciate is ugly but there is no nice way to do this (and
> support offline builds).
> 
> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel