From: Rob Landley <rob@landley.net>
To: linux-kernel@vger.kernel.org, Artem.Bityutskiy@nokia.com,
busybox@busybox.net
Subject: [BUG] Linux 3.0 commit 3627924acf70a broke include/mtd/ubi_user.h.
Date: Sun, 14 Aug 2011 12:45:35 -0500 [thread overview]
Message-ID: <4E4809BF.6040707@landley.net> (raw)
"make headers_install" copies include/mtd/ubi_user.h to userspace, where
things like busybox link against it. With 3.0, building defconfig
busybox gets this error:
In file included from miscutils/ubi_tools.c:63:
/home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:329:
error: conflicting types for '__packed'
/home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:313:
error: previous declaration of '__packed' was here
This is due to the Linux 3.0 commit in the title:
UBI: use __packed instead of __attribute__((packed))
This relies on __packed being defined in:
include/linux/compiler-gcc.h:
#define __packed __attribute__((packed))
Which is not exported to userspace.
I.E. this "cleanup" broke the ability for userspace to use this header,
even though the header is exported to userspace by headers_install.
Rob
next reply other threads:[~2011-08-14 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 17:45 Rob Landley [this message]
2011-08-14 18:03 ` [BUG] Linux 3.0 commit 3627924acf70a broke include/mtd/ubi_user.h Stefan Richter
2011-08-14 19:11 ` Rob Landley
2011-08-14 19:16 ` Rob Landley
2011-08-15 3:39 ` Artem Bityutskiy
2011-08-15 3:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4809BF.6040707@landley.net \
--to=rob@landley.net \
--cc=Artem.Bityutskiy@nokia.com \
--cc=busybox@busybox.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.