Re: [Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/12/2011 06:49 PM, Peter Maydell wrote:
> Don't use req before it has been initialised in scsi_req_new().
> This fixes a compile failure due to gcc complaining about this.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   hw/scsi-bus.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index f2af6cd..559d5a4 100644
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -372,7 +372,7 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, uint32_t lun,
>       } else {
>           trace_scsi_req_parsed(d->id, lun, tag, buf[0],
>                                 cmd.mode, cmd.xfer);
> -        if (req->cmd.lba != -1) {
> +        if (cmd.lba != -1) {
>               trace_scsi_req_parsed_lba(d->id, lun, tag, buf[0],
>                                         cmd.lba);
>           }

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo