From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Add CDMA voice call answering support
Date: Mon, 15 Aug 2011 00:58:39 -0500 [thread overview]
Message-ID: <4E48B58F.1090502@gmail.com> (raw)
In-Reply-To: <1313140749-28926-1-git-send-email-caiwen.zhang@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
Hi Caiwen,
On 08/12/2011 04:19 AM, Caiwen Zhang wrote:
> ---
> include/cdma-voicecall.h | 3 +++
> src/cdma-voicecall.c | 23 +++++++++++++++++++++++
> 2 files changed, 26 insertions(+), 0 deletions(-)
I applied this patch, however I broke it up into two:
06d45196a8f1e3617c529f9b008d4fa67f84aa92 and
e2be184afbd88cac07e086f5d9ae07133077ae95
In the future please structure your commits such that any new public API
additions (e.g. inside include/) are in a separate commit.
Regards,
-Denis
prev parent reply other threads:[~2011-08-15 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 9:19 [PATCH] Add CDMA voice call answering support Caiwen Zhang
2011-08-15 5:58 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E48B58F.1090502@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.