From: Kenneth Graunke <kenneth@whitecape.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: clear GFX_MODE on IVB at init time
Date: Mon, 15 Aug 2011 16:59:57 -0700 [thread overview]
Message-ID: <4E49B2FD.7010303@whitecape.org> (raw)
In-Reply-To: <20110812152832.6c922a17@jbarnes-desktop>
On 08/12/2011 03:28 PM, Jesse Barnes wrote:
> On Fri, 12 Aug 2011 15:18:09 -0700
> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
>> On Fri, 12 Aug 2011 14:55:32 -0700
>> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>>
>>> GFX_MODE controls important behavior like PPGTT, run lists, and TLB
>>> invalidate behavior. On the SDV I'm using, the TLB invalidation mode
>>> was defaulting to "pipe control only" which meant regular MI_FLUSHes
>>> wouldn't actually flush the TLB, leading to all sorts of stale data
>>> getting used.
>>>
>>> So initialize it to 0 at ring buffer init time until we actually use
>>> PIPE_CONTROL for TLB invalidation.
>>
>> Ignore this one, see below for an updated patch that uses bit
>> definitions and makes sure the register gets reset at GPU reset time as
>> well.
>
> Ignore the last one too. Third time's the charm!
Tested-by: Kenneth Graunke <kenneth@whitecape.org>
With drm-intel-next, I've been seeing frequent but intermittent
rendering corruption in GNOME Terminal, rendercheck failures, and the
occasional kernel crash.
After applying the patch, I was able to run for an entire day without
any crashes or rendering corruption. To double check, I reverted this
patch and was immediately able to reproduce my earlier problems.
With this patch and C0 hardware, my system seems quite stable. Thanks
Jesse!
prev parent reply other threads:[~2011-08-15 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 21:55 [PATCH 1/2] drm/i915: clear GFX_MODE on IVB at init time Jesse Barnes
2011-08-12 21:55 ` [PATCH 2/2] drm/i915: suspend/resume rps and ring freq state on IVB Jesse Barnes
2011-08-12 22:18 ` [PATCH 1/2] drm/i915: clear GFX_MODE on IVB at init time Jesse Barnes
2011-08-12 22:28 ` Jesse Barnes
2011-08-12 22:56 ` Chris Wilson
2011-08-15 23:59 ` Kenneth Graunke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E49B2FD.7010303@whitecape.org \
--to=kenneth@whitecape.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.