All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] armv7:cache: D cache line size read method
Date: Tue, 16 Aug 2011 15:24:38 +0400	[thread overview]
Message-ID: <4E4A5376.8040702@mvista.com> (raw)
In-Reply-To: <1313490709-20128-1-git-send-email-l.majewski@samsung.com>

Hello.

On 16-08-2011 14:31, Lukasz Majewski wrote:

> This commit adds support for reading the D cache line size for armv7
> architecture.

> The get_dcache_line_size() function is supposed to work in conjunction
> with memalign call to provide D cache aligned DMA buffers.

> Signed-off-by: Lukasz Majewski<l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> CC: Aneesh V<aneesh@ti.com>
> CC: Albert ARIBAUD<albert.u.boot@aribaud.net>
> ---
> Changes for v2:
> - Weak function get_dcache_line_size added to lib/cache.c for non armv7
> architectures
> ---
>   arch/arm/cpu/armv7/cache_v7.c |   15 +++++++++++++++
>   arch/arm/lib/cache.c          |   11 +++++++++++
>   include/common.h              |    1 +
>   3 files changed, 27 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c
> index 3e1e1bf..0ff9a97 100644
> --- a/arch/arm/cpu/armv7/cache_v7.c
> +++ b/arch/arm/cpu/armv7/cache_v7.c
> @@ -246,6 +246,21 @@ static void v7_inval_tlb(void)
>   	CP15ISB;
>   }
>
> +/* Read the cache line size (in bytes) */
> +int get_dcache_line_size(void)
> +{
> +	u32 ccsidr, log2_line_len;

    An empty line wounldn't hurt here.

> +	puts("222\n");

    Shouldn't that have been deleted?

WBR, Sergei

  reply	other threads:[~2011-08-16 11:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12  8:24 [U-Boot] [PATCH] armv7:cache: D cache line size read method Lukasz Majewski
2011-08-12  8:58 ` Albert ARIBAUD
2011-08-12  9:16   ` Aneesh V
2011-08-12  9:48     ` Albert ARIBAUD
2011-08-16 18:32     ` Anton Staaf
2011-08-12  9:02 ` Aneesh V
2011-08-12  9:46   ` Lukasz Majewski
2011-08-16 10:31 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2011-08-16 11:24   ` Sergei Shtylyov [this message]
2011-08-16 12:01 ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-08-17  8:51 ` [U-Boot] [PATCH v3] " Lukasz Majewski
2011-08-17 16:28   ` Albert ARIBAUD
2011-08-18  6:46 ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-08-23  6:13 ` [U-Boot] [PATCH v4] dcache: " Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4A5376.8040702@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.