From: Larry Finger <Larry.Finger@lwfinger.net>
To: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Matt Fleming <matt@console-pimps.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()
Date: Tue, 16 Aug 2011 15:27:49 -0500 [thread overview]
Message-ID: <4E4AD2C5.6080205@lwfinger.net> (raw)
In-Reply-To: <20110816193543.GD2803@mtj.dyndns.org>
On 08/16/2011 02:35 PM, Tejun Heo wrote:
> On Tue, Aug 16, 2011 at 08:50:57PM +0200, Oleg Nesterov wrote:
>> daemonize() is only needed when a user-space task does kernel_thread().
>>
>> r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
>> the soon-to-be-deprecated daemonize(). It is the only caller of
>> thread_enter() which actually does the call.
>>
>> Note:
>> - we are going to remove the sigdelset(blocked) code from
>> allow_signal(), this means that without this patch
>> thread_enter() can't work after that. Not to mention
>> daemonize() should be deprecated.
>>
>> - as a side effect, this patch changes ->comm. Hopefully
>> this is fine, and padapter->pnetdev->name probably makes
>> more sense anyway.
>>
>> Signed-off-by: Oleg Nesterov<oleg@redhat.com>
>
> Acked-by: Tejun Heo<tj@kernel.org>
Acked-and-tested-by: Larry Finger <Larry.Finger@lwfinger.net>
next prev parent reply other threads:[~2011-08-16 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 18:50 [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize() Oleg Nesterov
2011-08-16 19:35 ` Tejun Heo
2011-08-16 20:27 ` Larry Finger [this message]
2011-08-16 21:30 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4AD2C5.6080205@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.